From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A51C432C3 for ; Fri, 15 Nov 2019 11:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E82862073B for ; Fri, 15 Nov 2019 11:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727468AbfKOL4L (ORCPT ); Fri, 15 Nov 2019 06:56:11 -0500 Received: from mga12.intel.com ([192.55.52.136]:14859 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727223AbfKOL4L (ORCPT ); Fri, 15 Nov 2019 06:56:11 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 03:56:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,308,1569308400"; d="scan'208";a="214766740" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 15 Nov 2019 03:56:07 -0800 Received: by lahna (sSMTP sendmail emulation); Fri, 15 Nov 2019 13:56:07 +0200 Date: Fri, 15 Nov 2019 13:56:07 +0200 From: Mika Westerberg To: linux-kernel@vger.kernel.org Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Lukas Wunner , Mario.Limonciello@dell.com, Christian Kellner , zang Subject: Re: [PATCH] thunderbolt: Power cycle the router if NVM authentication fails Message-ID: <20191115115607.GA34425@lahna.fi.intel.com> References: <20191112092452.70789-1-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112092452.70789-1-mika.westerberg@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2019 at 12:24:52PM +0300, Mika Westerberg wrote: > On zang's Dell XPS 13 9370 after Thunderbolt NVM firmware upgrade the > Thunderbolt controller did not come back as expected. Only after the > system was rebooted it became available again. It is not entirely clear > what happened but I suspect the new NVM firmware image authentication > failed for some reason. Regardless of this the router needs to be power > cycled if NVM authentication fails in order to get it fully functional > again. > > This modifies the driver to issue a power cycle in case the NVM > authentication fails immediately when dma_port_flash_update_auth() > returns. We also need to call tb_switch_set_uuid() earlier to be able to > fetch possible NVM authentication failure when DMA port is added. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=205457 > Reported-by: zang > Signed-off-by: Mika Westerberg > --- > This applies on top of my thunderbolt.git/next. Applied to thunderbolt.git/next.