From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6635C432C3 for ; Fri, 15 Nov 2019 18:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90BC920674 for ; Fri, 15 Nov 2019 18:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfKOSBH (ORCPT ); Fri, 15 Nov 2019 13:01:07 -0500 Received: from mga04.intel.com ([192.55.52.120]:16528 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfKOSBE (ORCPT ); Fri, 15 Nov 2019 13:01:04 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 10:00:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,309,1569308400"; d="scan'208";a="208487219" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 15 Nov 2019 10:00:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id A9AAFD4; Fri, 15 Nov 2019 20:00:55 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, Christoph Hellwig Cc: Andy Shevchenko , Dan Williams , Marek Szyprowski , Robin Murphy Subject: [PATCH v1 2/5] dma-mapping: Drop duplicate check for size parameter of memremap() Date: Fri, 15 Nov 2019 20:00:41 +0200 Message-Id: <20191115180044.83659-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191115180044.83659-1-andriy.shevchenko@linux.intel.com> References: <20191115180044.83659-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since memremap() returns NULL pointer for size = 0, there is no need to duplicate this check in the callers. Cc: Christoph Hellwig Cc: Dan Williams Cc: Marek Szyprowski Cc: Robin Murphy Signed-off-by: Andy Shevchenko --- kernel/dma/coherent.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c index 551b0eb7028a..7e669c083324 100644 --- a/kernel/dma/coherent.c +++ b/kernel/dma/coherent.c @@ -42,16 +42,11 @@ static int dma_init_coherent_memory(phys_addr_t phys_addr, struct dma_coherent_mem **mem) { struct dma_coherent_mem *dma_mem = NULL; - void *mem_base = NULL; + void *mem_base; int pages = size >> PAGE_SHIFT; int bitmap_size = BITS_TO_LONGS(pages) * sizeof(long); int ret; - if (!size) { - ret = -EINVAL; - goto out; - } - mem_base = memremap(phys_addr, size, MEMREMAP_WC); if (!mem_base) { ret = -EINVAL; -- 2.24.0