From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4DDC43141 for ; Sat, 16 Nov 2019 16:15:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA00921479 for ; Sat, 16 Nov 2019 16:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573920939; bh=FknDXqjToftO/T1ZTrO4rNNhR0VU4cU3YPNxDSoszY0=; h=From:To:Cc:Subject:Date:List-ID:From; b=sHtIAFYja3DPCPe+ARhylvNzI8fed2/TaSSRz7O97Gt5ZChFW5qyqY/HE/nkUR9w5 RU1eSEshK8RVFOebA/bdAGbXutQaLLrJHtag2a/IL5HDi0PG5+nK5emss0f7vmHcPx Il87Z4O0r+cIe4BIPNB5FwW7hcpGXboDqZfdPxdg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731946AbfKPQPi (ORCPT ); Sat, 16 Nov 2019 11:15:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:54180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729504AbfKPPra (ORCPT ); Sat, 16 Nov 2019 10:47:30 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B03F620740; Sat, 16 Nov 2019 15:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573919250; bh=FknDXqjToftO/T1ZTrO4rNNhR0VU4cU3YPNxDSoszY0=; h=From:To:Cc:Subject:Date:From; b=KfN2Soc6F3LeBzUe+gycVKNRsX+vE8Tl5b3frrSJnbc7TXn+bCsBCnlbxPrYaFXLA yg6hJICv9yF3LnWaLCPKpcv4eoANIFvm4X2jM7DfK7hhjP6VLcs0cQOdQiO45QJuHC M4c96585cirv4fLDf4L/V0g4G94fTTEX0oHJNK1g= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Takashi Sakamoto , Takashi Iwai , Sasha Levin Subject: [PATCH AUTOSEL 4.14 001/150] ALSA: isight: fix leak of reference to firewire unit in error path of .probe callback Date: Sat, 16 Nov 2019 10:44:59 -0500 Message-Id: <20191116154729.9573-1-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Sakamoto [ Upstream commit 51e68fb0929c29e47e9074ca3e99ffd6021a1c5a ] In some error paths, reference count of firewire unit is not decreased. This commit fixes the bug. Fixes: 5b14ec25a79b('ALSA: firewire: release reference count of firewire unit in .remove callback of bus driver') Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/firewire/isight.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c index 5826aa8362f10..9edb26ab16e90 100644 --- a/sound/firewire/isight.c +++ b/sound/firewire/isight.c @@ -639,7 +639,7 @@ static int isight_probe(struct fw_unit *unit, if (!isight->audio_base) { dev_err(&unit->device, "audio unit base not found\n"); err = -ENXIO; - goto err_unit; + goto error; } fw_iso_resources_init(&isight->resources, unit); @@ -668,12 +668,12 @@ static int isight_probe(struct fw_unit *unit, dev_set_drvdata(&unit->device, isight); return 0; - -err_unit: - fw_unit_put(isight->unit); - mutex_destroy(&isight->mutex); error: snd_card_free(card); + + mutex_destroy(&isight->mutex); + fw_unit_put(isight->unit); + return err; } -- 2.20.1