From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8C2C432C0 for ; Mon, 18 Nov 2019 08:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22D7420718 for ; Mon, 18 Nov 2019 08:41:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jfd0/U8B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbfKRIlm (ORCPT ); Mon, 18 Nov 2019 03:41:42 -0500 Received: from merlin.infradead.org ([205.233.59.134]:50142 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbfKRIll (ORCPT ); Mon, 18 Nov 2019 03:41:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dXXkS46PVE3sNT71s/1r4g0ytwhoCjC2DYQhfYZ/Kfs=; b=jfd0/U8BAdSsF3bBZRn5mH41F 3kXcSCJIHkzUglNOLp6wI4BgGDlFitQ4kQVY1Kl50O6+DJeXfnoOT97pQR1XzQMZMyqNKX+Qeym+f RdHI6iX68FKHp+Zdv0eB5T5b3HgQ1GNO5C5ea6e2NR4lGZ5nmqKKmyNM2MxQYogGGcQkI6gk0H728 UzU86I14xNNEBUKMLWPL0u1LzkP7lOZjy2orjkyxV926AYkdWa//o4usSXlEDdbma7X92NuJUPBg2 milEjOUbRp1bDerC0ge3jx9W4Si+pMZiPOQwe8zQaUFQE7UljWvMXnEM6O0BvYcp0ZWL9vDUxYqdV b1H0lY0ZQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWcak-0007EG-1e; Mon, 18 Nov 2019 08:41:02 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D37773011EC; Mon, 18 Nov 2019 09:39:49 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 42F5C2B133330; Mon, 18 Nov 2019 09:40:59 +0100 (CET) Date: Mon, 18 Nov 2019 09:40:59 +0100 From: Peter Zijlstra To: Joe Perches Cc: Ian Rogers , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Morton , Masahiro Yamada , Kees Cook , Catalin Marinas , Petr Mladek , Mauro Carvalho Chehab , Qian Cai , Joe Lawrence , Tetsuo Handa , Sri Krishna chowdary , "Uladzislau Rezki (Sony)" , Andy Shevchenko , Changbin Du , Ard Biesheuvel , "David S. Miller" , Kent Overstreet , Gary Hook , Arnd Bergmann , Kan Liang , linux-kernel@vger.kernel.org, Stephane Eranian , Andi Kleen Subject: Re: [PATCH v3 02/10] lib: introduce generic min max heap Message-ID: <20191118084059.GU4131@hirez.programming.kicks-ass.net> References: <20191114003042.85252-1-irogers@google.com> <20191114003042.85252-3-irogers@google.com> <7d369058842123c3038d10a631f5fa4c3e7472ff.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d369058842123c3038d10a631f5fa4c3e7472ff.camel@perches.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 17, 2019 at 10:28:09AM -0800, Joe Perches wrote: > On Wed, 2019-11-13 at 16:30 -0800, Ian Rogers wrote: > > Based-on-work-by: Peter Zijlstra (Intel) > > Perhaps some functions are a bit large for inline It all hard relies on always inline to have the indirect function pointers constant folded and inlined too. See for example also: include/linux/rbtree_augmented.h Yes, its a bit crud, but performance mandates it. > and perhaps the function names are too generic? Yeah, noted that already.