From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
"Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>, Yi Liu <yi.l.liu@intel.com>,
Eric Auger <eric.auger@redhat.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 07/10] iommu/vt-d: Replace Intel specific PASID allocator with IOASID
Date: Mon, 18 Nov 2019 10:50:08 -0800 [thread overview]
Message-ID: <20191118105008.02140761@jacob-builder> (raw)
In-Reply-To: <517dcd76-8bc6-45c0-6d0d-baec6b6d0d53@linux.intel.com>
On Mon, 18 Nov 2019 09:43:00 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> Hi,
>
> On 11/16/19 7:09 AM, Jacob Pan wrote:
> > Make use of generic IOASID code to manage PASID allocation,
> > free, and lookup. Replace Intel specific code.
> > IOASID allocator is inclusive for both start and end of the
> > allocation range. The current code is based on IDR, which is
> > exclusive for the end of the allocation range. This patch fixes the
> > off-by-one error in intel_svm_bind_mm, where pasid_max - 1 is used
> > for the end of allocation range.
> >
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>
> Two nit comments in line. With that fixed,
>
> Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
>
Thanks, will fix below.
> Best regards,
> baolu
>
> [...]
>
> Nit - short line within 80 characters and align the new line with
> open parenthesis.
>
> [...]
>
> Nit - open parenthesis alignment.
>
> [...]
[Jacob Pan]
next prev parent reply other threads:[~2019-11-18 18:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 23:09 [PATCH 00/10] VT-d Native Shared virtual memory cleanup and fixes Jacob Pan
2019-11-15 23:09 ` [PATCH 01/10] iommu/vt-d: Introduce native SVM capable flag Jacob Pan
2019-11-18 1:19 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 02/10] iommu/vt-d: Fix CPU and IOMMU SVM feature matching checks Jacob Pan
2019-11-18 1:20 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 03/10] iommu/vt-d: Reject SVM bind for failed capability check Jacob Pan
2019-11-18 1:30 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 04/10] iommu/vt-d: Match CPU and IOMMU paging mode Jacob Pan
2019-11-18 1:31 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 05/10] iommu/vt-d: Avoid duplicated code for PASID setup Jacob Pan
2019-11-18 1:33 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 06/10] iommu/vt-d: Fix off-by-one in PASID allocation Jacob Pan
2019-11-18 1:34 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 07/10] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Jacob Pan
2019-11-18 1:43 ` Lu Baolu
2019-11-18 18:50 ` Jacob Pan [this message]
2019-11-15 23:09 ` [PATCH 08/10] iommu/vt-d: Fix PASID cache flush Jacob Pan
2019-11-18 1:43 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 09/10] iommu/vt-d: Avoid sending invalid page response Jacob Pan
2019-11-18 1:54 ` Lu Baolu
2019-11-15 23:09 ` [PATCH 10/10] iommu/vt-d: Misc macro clean up for SVM Jacob Pan
2019-11-18 2:23 ` Lu Baolu
2019-11-18 18:36 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118105008.02140761@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox