From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301F2C432C0 for ; Mon, 18 Nov 2019 11:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F164820748 for ; Mon, 18 Nov 2019 11:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574077623; bh=kDnVWqM8rv4v0DFbARQKnL4pnCPNws5EF5tS19PJ2+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=m0LClATD3sid/Ib4rZRZ+UZ5JQiT5ukm5aBgBLMrtKgKWB/tXcL0KDFWzDn2/ah+h RkvHYwpCHtMfcG8HgO4KGpMdR5v3HZyYYdreErtpnO8Jsy8UYNnp7h4lxlowpOEVnl K7UU/KSKUawtCMRlKZ7GI2F3RXfAyhbmNSzQoUHo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbfKRLrC (ORCPT ); Mon, 18 Nov 2019 06:47:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:54756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbfKRLrB (ORCPT ); Mon, 18 Nov 2019 06:47:01 -0500 Received: from localhost (unknown [89.205.134.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FB5820730; Mon, 18 Nov 2019 11:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574077621; bh=kDnVWqM8rv4v0DFbARQKnL4pnCPNws5EF5tS19PJ2+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=feKrCvQ/m8Ef+oJobtODMFU/XcxXBRqauk0eAksInQzk60LFEAgNKobEQ/8djXNv5 SdqcRwonoa3KFQt2IANfPfJy1hUC6al1156N2ZzeXxFqzBcrATsNn3ry8d6fDDotjk aJ+T9NNv1Sxv4LKP2WJOIGl1ohIEsJFHgpW31F1E= Date: Mon, 18 Nov 2019 12:46:57 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Kyungmin Park , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jiri Slaby , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning Message-ID: <20191118114657.GA228826@kroah.com> References: <20191117202435.28127-1-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191117202435.28127-1-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 17, 2019 at 08:24:35PM +0000, Sudip Mukherjee wrote: > Any arm config which has 'CONFIG_MTD_ONENAND_SAMSUNG=m' and > 'CONFIG_SERIAL_SAMSUNG=m' gives a build warning: > > warning: same module names found: > drivers/tty/serial/samsung.ko > drivers/mtd/nand/onenand/samsung.ko > > Rename both drivers/tty/serial/samsung.c to > drivers/tty/serial/samsung_tty.c and drivers/mtd/nand/onenand/samsung.c > drivers/mtd/nand/onenand/samsung_mtd.c to fix the warning. > > Signed-off-by: Sudip Mukherjee > --- > > v1: only renamed drivers/tty/serial/samsung.c > link: https://lore.kernel.org/lkml/20191018194707.27188-1-sudipm.mukherjee@gmail.com > > v2: rename both files. > > I was not sure if this should have been two different patch, but since > this will be fixing the same problem so it seems its better to have them > in a single patch. > > drivers/mtd/nand/onenand/Makefile | 2 +- > drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0 > drivers/tty/serial/Makefile | 2 +- > drivers/tty/serial/{samsung.c => samsung_tty.c} | 0 > 4 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%) > rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%) I can take this in the tty tree if the mtd maintainer gives an ack for it...