From: Pavel Machek <pavel@denx.de>
To: kan.liang@linux.intel.com
Cc: peterz@infradead.org, mingo@kernel.org, sashal@kernel.org,
gregkh@linuxfoundation.org, pavel@denx.de,
linux-kernel@vger.kernel.org, ak@linux.intel.com,
alexander.shishkin@linux.intel.com, stable@vger.kernel.org
Subject: Re: [PATCH] perf/x86/uncore: Remove unnecessary check for uncore_pmu
Date: Mon, 18 Nov 2019 15:36:36 +0100 [thread overview]
Message-ID: <20191118143636.GD22736@duo.ucw.cz> (raw)
In-Reply-To: <1573652102-131731-1-git-send-email-kan.liang@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Wed 2019-11-13 05:35:02, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The uncore_pmu pointer in uncore_pmu_enable/disable() is from
> container_of, which never be NULL.
>
> Remove the unnecessary check for uncore_pmu.
>
> Fixes: 75be6f703a14 ("perf/x86/uncore: Fix event group support")
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: stable@vger.kernel.org
Sorry, sent email too fast.
I agree this is good fix for mainline, but as the code is a tiny bit
ineffective but correct, I don't think we neccessarily need it in
stable.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2019-11-18 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 13:35 [PATCH] perf/x86/uncore: Remove unnecessary check for uncore_pmu kan.liang
2019-11-18 14:35 ` Pavel Machek
2019-11-18 14:36 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118143636.GD22736@duo.ucw.cz \
--to=pavel@denx.de \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox