From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12E7C432C0 for ; Tue, 19 Nov 2019 16:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A3B222384 for ; Tue, 19 Nov 2019 16:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbfKSQma (ORCPT ); Tue, 19 Nov 2019 11:42:30 -0500 Received: from muru.com ([72.249.23.125]:42922 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727560AbfKSQma (ORCPT ); Tue, 19 Nov 2019 11:42:30 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3890F809B; Tue, 19 Nov 2019 16:43:07 +0000 (UTC) Date: Tue, 19 Nov 2019 08:42:27 -0800 From: Tony Lindgren To: "Andrew F. Davis" Cc: Mark Rutland , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available Message-ID: <20191119164227.GL35479@atomide.com> References: <20191118165236.22136-1-afd@ti.com> <20191118215759.GD35479@atomide.com> <20191118223128.GE35479@atomide.com> <29db708e-119e-8a89-7d43-e38e2a10dc07@ti.com> <20191119162157.GJ35479@atomide.com> <6e009ae3-6aa2-409b-749f-4947303940d8@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e009ae3-6aa2-409b-749f-4947303940d8@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andrew F. Davis [191119 16:31]: > arm_smccc_smc() only works on mach-omap2 platforms when OP-TEE is > available. On older system or systems where OP-TEE has not been > installed we need to fall back to our custom smc() calls. Hmm OK so optee probably just adds support for new functions when loaded. Do the old bootrom functions stop working if optee is loaded? If arm_smccc_smc() working depends on optee firmware being loaded and the old omap_smc1 won't work, then you should configure the function on init or dynamically modify the code like we do in smp_on_up case for example. What I'd like to have though is to make arm_smccc_smc() work for optee and non-optee case for mach-omap2 as it already has the features necessary to do the runtime patching of the code for the quirks. Mark do you have any comments on this? Regards, Tony