From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: 'Daniel Wagner' <dwagner@suse.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
linkinjeon@gmail.com, Markus.Elfring@web.de,
sj1557.seo@samsung.com
Subject: Re: [PATCH v2 02/13] exfat: add super block operations
Date: Tue, 19 Nov 2019 18:17:52 +0100 [thread overview]
Message-ID: <20191119171752.GA20042@lst.de> (raw)
In-Reply-To: <00d101d59eba$dcc373c0$964a5b40$@samsung.com>
On Tue, Nov 19, 2019 at 06:22:28PM +0900, Namjae Jeon wrote:
> > No idea what the code does. But I was just skimming over and find the
> > above pattern somehow strange. Shouldn't this be something like
> Right.
>
> >
> > if (!READ_ONCE(sbi->s_dirt)) {
> > WRITE_ONCE(sbi->s_dirt, true);
>
> It should be :
> if (READ_ONCE(sbi->s_dirt)) {
> WRITE_ONCE(sbi->s_dirt, false);
> I will fix it on v3.
The other option would be to an unsigned long flags field and define
bits flags on it, then use test_and_set_bit, test_and_clear_bit etc.
Which might be closer to the pattern we use elsewhere in the kernel.
next prev parent reply other threads:[~2019-11-19 17:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191119071401epcas1p4a42c781276e89928a24d53379fe13d64@epcas1p4.samsung.com>
2019-11-19 7:10 ` [PATCH v2 00/13] add the latest exfat driver Namjae Jeon
2019-11-19 7:10 ` [PATCH v2 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-11-20 9:22 ` Nikolay Borisov
2019-11-19 7:10 ` [PATCH v2 02/13] exfat: add super block operations Namjae Jeon
2019-11-19 8:56 ` Daniel Wagner
2019-11-19 9:22 ` Namjae Jeon
2019-11-19 17:17 ` Christoph Hellwig [this message]
2019-11-20 4:33 ` Namjae Jeon
2019-11-19 7:10 ` [PATCH v2 03/13] exfat: add inode operations Namjae Jeon
2019-11-19 7:10 ` [PATCH v2 04/13] exfat: add directory operations Namjae Jeon
2019-11-19 7:10 ` [PATCH v2 05/13] exfat: add file operations Namjae Jeon
2019-11-20 9:14 ` Nikolay Borisov
2019-11-21 1:42 ` Namjae Jeon
2019-11-21 3:18 ` Valdis Klētnieks
2019-11-21 3:39 ` Namjae Jeon
2019-11-19 7:11 ` [PATCH v2 06/13] exfat: add exfat entry operations Namjae Jeon
2019-11-20 9:19 ` Nikolay Borisov
2019-11-19 7:11 ` [PATCH v2 07/13] exfat: add bitmap operations Namjae Jeon
2019-11-20 9:24 ` Nikolay Borisov
2019-11-19 7:11 ` [PATCH v2 08/13] exfat: add exfat cache Namjae Jeon
2019-11-19 7:11 ` [PATCH v2 09/13] exfat: add misc operations Namjae Jeon
2020-01-08 19:53 ` Arnd Bergmann
2020-01-09 23:35 ` Namjae Jeon
2019-11-19 7:11 ` [PATCH v2 10/13] exfat: add nls operations Namjae Jeon
2019-11-19 7:11 ` [PATCH v2 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2019-11-19 7:11 ` [PATCH v2 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2019-11-19 7:11 ` [PATCH v2 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119171752.GA20042@lst.de \
--to=hch@lst.de \
--cc=Markus.Elfring@web.de \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox