Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available

Tony Lindgren
2019-11-19T16:30:18Z

* Tony Lindgren <tony@atomide.com> [191119 16:22]:
> * Andrew F. Davis <afd@ti.com> [191119 01:14]:
> > A generic smc() call would be nice, but arm_smccc_smc() is specifically
> > for SMCCC.
>
> To me it seeems that HAVE_ARM_SMCCC is a generic feature though.
> It's not limited to OPTEE. We have select HAVE_ARM_SMCCC if CPU_V7
> in arch/arm/Kconfig, and OPTEE depends on HAVE_ARM_SMCCC.
>
> From that point of view it seems that we could have HAVE_ARM_SMCCC
> enabled also for v6 and use it for all mach-omap2 with a wrapper.

In the omap_smc1 case it seems that we can just unconditionally
change the callers to use arm_smccc_smc() instead of omap_smc1
and get rid of it. It's only used by v7 SMP related stuff based
on grepping for it.

> So I'd like to have our smc callers eventually just call generic
> generic arm_smccc_smc(OMAP_SIP_SMC_STD_CALL_VAL(fn)...) rather
> than the custom calls. And we want to update to using the generic
> functions one case at a time as the features get tested :)

Sounds like the others can be then done one at a time as
needed :)

Regards,

Tony