From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 1/2] perf util: Move block tui function to ui browsers
Date: Tue, 19 Nov 2019 19:37:34 -0300 [thread overview]
Message-ID: <20191119223734.GE24290@kernel.org> (raw)
In-Reply-To: <20191119200927.GB7364@krava>
Em Tue, Nov 19, 2019 at 09:09:27PM +0100, Jiri Olsa escreveu:
> On Mon, Nov 18, 2019 at 10:08:48PM +0800, Jin Yao wrote:
> > It would be nice if we could jump to the assembler/source view
> > (like the normal perf report) from total cycles view.
> >
> > This patch moves the block_hists_tui_browse from block-info.c
> > to ui/browsers/hists.c in order to reuse some browser codes
> > (i.e do_annotate) for implementing new annotation view.
> >
> > v2:
> > ---
> > Fix the 'make NO_SLANG=1' error. (Change 'int block_hists_tui_browse()'
> > to 'static inline int block_hists_tui_browse()')
> >
> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>
> for both patches
>
> Acked-by: Olsa <jolsa@redhat.com>
Thanks, tested and applied.
- Arnaldo
next prev parent reply other threads:[~2019-11-19 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 14:08 [PATCH v2 1/2] perf util: Move block tui function to ui browsers Jin Yao
2019-11-18 14:08 ` [PATCH v2 2/2] perf report: Jump to symbol source view from total cycles view Jin Yao
2019-11-23 8:15 ` [tip: perf/core] " tip-bot2 for Jin Yao
2019-11-19 20:09 ` [PATCH v2 1/2] perf util: Move block tui function to ui browsers Jiri Olsa
2019-11-19 22:37 ` Arnaldo Carvalho de Melo [this message]
2019-11-23 8:15 ` [tip: perf/core] perf util: Move block TUI " tip-bot2 for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119223734.GE24290@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox