Re: [PATCH] ARM: don't export unused return_address()

Russell King - ARM Linux admin
2019-11-13T11:45:32Z

On Wed, Nov 13, 2019 at 08:40:39PM +0900, Masahiro Yamada wrote:
> On Tue, Oct 1, 2019 at 11:31 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Arnd,
> >
> > On Fri, Sep 6, 2019 at 5:47 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > > Without the frame pointer enabled, return_address() is an inline
> > > function and does not need to be exported, as shown by this warning:
> > >
> > > WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL
> > >
> > > Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Thanks for your patch!
> >
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > --- a/arch/arm/kernel/return_address.c
> > > +++ b/arch/arm/kernel/return_address.c
> > > @@ -53,6 +53,7 @@ void *return_address(unsigned int level)
> > > return NULL;
> > > }
> > >
> >
> > Checkpatch doesn't like the empty line above:
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> >
> > > +EXPORT_SYMBOL_GPL(return_address);
> > > +
> > > #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
> > >
> > > -EXPORT_SYMBOL_GPL(return_address);
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > -- Linus Torvalds
>
>
>
> What has happened to this patch?
>
> I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped.
A new version is pending me doing another round of patch merging.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up