From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414D0C43215 for ; Wed, 20 Nov 2019 09:03:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 261A62243F for ; Wed, 20 Nov 2019 09:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728135AbfKTJDu convert rfc822-to-8bit (ORCPT ); Wed, 20 Nov 2019 04:03:50 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:34301 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727814AbfKTJDt (ORCPT ); Wed, 20 Nov 2019 04:03:49 -0500 X-Originating-IP: 90.76.211.102 Received: from xps13 (lfbn-1-2154-102.w90-76.abo.wanadoo.fr [90.76.211.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 54F251C0016; Wed, 20 Nov 2019 09:03:46 +0000 (UTC) Date: Wed, 20 Nov 2019 10:03:45 +0100 From: Miquel Raynal To: Greg Kroah-Hartman Cc: Richard Weinberger , Sudip Mukherjee , Kyungmin Park , Vignesh Raghavendra , Jiri Slaby , linux-kernel , linux-mtd , linux-serial Subject: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning Message-ID: <20191120100345.038dd232@xps13> In-Reply-To: <20191118194010.GA606660@kroah.com> References: <20191117202435.28127-1-sudipm.mukherjee@gmail.com> <20191118114657.GA228826@kroah.com> <1505628642.90849.1574081270290.JavaMail.zimbra@nod.at> <20191118202257.6cfd1a7e@xps13> <884028732.91086.1574105504462.JavaMail.zimbra@nod.at> <20191118194010.GA606660@kroah.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, Greg Kroah-Hartman wrote on Mon, 18 Nov 2019 20:40:10 +0100: > On Mon, Nov 18, 2019 at 08:31:44PM +0100, Richard Weinberger wrote: > > ----- Ursprüngliche Mail ----- > > > Von: "Miquel Raynal" > > > An: "richard" > > > CC: "Greg Kroah-Hartman" , "Sudip Mukherjee" , "Kyungmin Park" > > > , "Vignesh Raghavendra" , "Jiri Slaby" , "linux-kernel" > > > , "linux-mtd" , "linux-serial" > > > > > > Gesendet: Montag, 18. November 2019 20:22:57 > > > Betreff: Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning > > > > > Hi all, > > > > > > Richard Weinberger wrote on Mon, 18 Nov 2019 13:47:50 > > > +0100 (CET): > > > > > >> ----- Ursprüngliche Mail ----- > > >> >> I was not sure if this should have been two different patch, but since > > >> >> this will be fixing the same problem so it seems its better to have them > > >> >> in a single patch. > > >> >> > > >> >> drivers/mtd/nand/onenand/Makefile | 2 +- > > >> >> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0 > > >> >> drivers/tty/serial/Makefile | 2 +- > > >> >> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0 > > >> >> 4 files changed, 2 insertions(+), 2 deletions(-) > > >> >> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%) > > >> >> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%) > > >> > > > >> > I can take this in the tty tree if the mtd maintainer gives an ack for > > >> > it... > > >> > > >> Acked-by: Richard Weinberger > > > > > > If it is not too late, I am not a big fan of the new naming which is > > > rather not descriptive. Files in the onenand subdirectory are: > > > * onenand_.c for the base files > > > * .c for the vendors files (currently: omap2.c and samsung.c). > > > > Well, I'm fine with the naming either way. :-) > > If you want to rename the mtd driver later, that's fine, I'll take this > for now for 5.5-rc1 and you all can bikeshed it for 5.5-final :) Let's not rename it twice, if nobody want's another naming I'm fine with this one. Acked-by: Miquel Raynal Cheers! Miquèl