From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50512C432C0 for ; Wed, 20 Nov 2019 14:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22193224C0 for ; Wed, 20 Nov 2019 14:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574258536; bh=jfz7QwK1/Lbu7Y8QvbmT43l6h208/pDDBUvroUJR59A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BflBM1uUscI39Il9XJ65c+Xt+vAp9BvBt2vfvHAFpIzz47Bvy6X8e6tm455Rw7HFb l0AqWBm2IZ6B/b4nTQy6EAIVdljiqLmwPiCcxIW7UZli8W6omfIs55sy7Eu3hRhmh6 uivPzMQlD0BWZE0tsN6cOKT11wqbRTe1628ewdDM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731620AbfKTOCP (ORCPT ); Wed, 20 Nov 2019 09:02:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:59804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727988AbfKTOCO (ORCPT ); Wed, 20 Nov 2019 09:02:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADDEE2235D; Wed, 20 Nov 2019 14:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574258534; bh=jfz7QwK1/Lbu7Y8QvbmT43l6h208/pDDBUvroUJR59A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WWxURQera4DoHBCY2JpT7xtu3u6iqH4TRSUGv8GlKCeRWIDmS+FtWsBylVOFNcuFC oN5pgVWzzI/bVLIu1bNkXccHEwA9Ihcj7JFk1z4tpOQ5cAh72DeM8kmRBiXZ36sEs9 10rf73NPkX6sE+J9lVOMDSr3gOC6Gx3T5l+rujfA= Date: Wed, 20 Nov 2019 15:02:11 +0100 From: Greg Kroah-Hartman To: patrick.rudolph@9elements.com Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Alexios Zavras , Allison Randal , Stephen Boyd , Julius Werner , Samuel Holland Subject: Re: [PATCH 1/2] firmware: google: Expose CBMEM over sysfs Message-ID: <20191120140211.GA2935300@kroah.com> References: <20191120133958.13160-1-patrick.rudolph@9elements.com> <20191120133958.13160-2-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120133958.13160-2-patrick.rudolph@9elements.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 20, 2019 at 02:39:46PM +0100, patrick.rudolph@9elements.com wrote: > +static int cbmem_probe(struct coreboot_device *cdev) > +{ > + struct device *dev = &cdev->dev; > + struct cb_priv *priv; > + int err; > + > + priv = kzalloc(sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + memcpy(&priv->entry, &cdev->cbmem_entry, sizeof(priv->entry)); > + > + priv->remap = memremap(priv->entry.address, > + priv->entry.entry_size, MEMREMAP_WB); > + if (!priv->remap) { > + err = -ENOMEM; > + goto failure; > + } > + > + err = sysfs_create_group(&dev->kobj, &cb_mem_attr_group); Ick, you just raced userspace and lost :( Please set the default group for the driver (dev_groups), so that the driver core will correctly create and remove this group without you having to do anything. thanks, greg k-h