From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82812C432C0 for ; Fri, 22 Nov 2019 06:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51EB420674 for ; Fri, 22 Nov 2019 06:23:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574403796; bh=CrI0/ZIICBLBt4Quh91vZZVcOFT//RP6JUGfUOsnkPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bZDCGYtLeSKq0En2C0wKY26uKGB6Ka9VX4LQhJ1fb+pZoipc5+KLPtdXFhVUHV993 7KkM5keaur5j3aCImTt4lCP3PRKIoHQxEq1O/YSxMu6yfchkKIte7qSO/pB6Jov1KK 2d50ISsAPrvaXu/ZF32w6zxf82M38nCqghdMpUEg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbfKVFvs (ORCPT ); Fri, 22 Nov 2019 00:51:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:56904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728235AbfKVFvm (ORCPT ); Fri, 22 Nov 2019 00:51:42 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F003820731; Fri, 22 Nov 2019 05:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574401901; bh=CrI0/ZIICBLBt4Quh91vZZVcOFT//RP6JUGfUOsnkPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tWzc91neL8NozOhwlDILI92fsFlDkNxKRbxlS17XWcGhFXdX0y4q486ee2tv/T+bj zjlUaWJuzZCv32svg9JwX8SC0Pabt2blY8mJ0qTTJIdgIgGiGKtd01VuzmacWPj94S oC2svGPAerbd2LTqR1+mBkG+jU766Do/pSoDBRsg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Ellerman , Sasha Levin , linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 133/219] powerpc/pseries: Fix node leak in update_lmb_associativity_index() Date: Fri, 22 Nov 2019 00:47:45 -0500 Message-Id: <20191122054911.1750-126-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122054911.1750-1-sashal@kernel.org> References: <20191122054911.1750-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Ellerman [ Upstream commit 47918bc68b7427e961035949cc1501a864578a69 ] In update_lmb_associativity_index() we lookup dr_node using of_find_node_by_path() which takes a reference for us. In the non-error case we forget to drop the reference. Note that find_aa_index() does modify properties of the node, but doesn't need an extra reference held once it's returned. Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/platforms/pseries/hotplug-memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c index f99cd31b6fd1a..8a1c2c8963214 100644 --- a/arch/powerpc/platforms/pseries/hotplug-memory.c +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c @@ -202,6 +202,7 @@ static u32 lookup_lmb_associativity_index(struct drmem_lmb *lmb) aa_index = find_aa_index(dr_node, ala_prop, lmb_assoc); + of_node_put(dr_node); dlpar_free_cc_nodes(lmb_node); return aa_index; } -- 2.20.1