From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 343F7C432C0 for ; Fri, 22 Nov 2019 06:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 034A72068E for ; Fri, 22 Nov 2019 06:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574402460; bh=G+dN70EWZVxlSDhL9Zb00I684se8PKnfRkgk/5cWS/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NhbplL1q5FXeM64LJBwGN238kaD9SNj+or1e6h7N1ILwiFs4cjaU2ywCfR6pYJ9UV gpXXIVOrS7R0IHOhMcgH68y5J3X39dkexcf/k3gkVF17MIbxlrT8fR5iI4i8j7uVyZ HsMNvJOOlmIL3l/LcJiYA3llRgrTGepotRnmgyl8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728795AbfKVGA6 (ORCPT ); Fri, 22 Nov 2019 01:00:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:35750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729424AbfKVF5Z (ORCPT ); Fri, 22 Nov 2019 00:57:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 529EB20659; Fri, 22 Nov 2019 05:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574402245; bh=G+dN70EWZVxlSDhL9Zb00I684se8PKnfRkgk/5cWS/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d+788cd2Vxhdsm2YBttHCrgfGMYEvqpg2qTE5Gl2Fduo4PIpYaIzVVKap2n0iCCCY 2Tx+57TtuJyFAuTpVnCvM/HmlpbUESmMWnqrc5yHI13Q/PMBj9+6A0h2agbGcI5Th8 +EO6QvNhFDMEVllyydSMZHhCIOUw1tzxZKtCasfA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.14 089/127] tipc: fix a missing check of genlmsg_put Date: Fri, 22 Nov 2019 00:55:07 -0500 Message-Id: <20191122055544.3299-88-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122055544.3299-1-sashal@kernel.org> References: <20191122055544.3299-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit 46273cf7e009231d2b6bc10a926e82b8928a9fb2 ] genlmsg_put could fail. The fix inserts a check of its return value, and if it fails, returns -EMSGSIZE. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/netlink_compat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 1c8ac0c11008c..91d51a595ac23 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -974,6 +974,8 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock) hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI, TIPC_NL_PUBL_GET); + if (!hdr) + return -EMSGSIZE; nest = nla_nest_start(args, TIPC_NLA_SOCK); if (!nest) { -- 2.20.1