Re: [PATCH 4.19 025/220] SUNRPC: Fix priority queue fairness

Pavel Machek
2019-11-24T09:21:49Z

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On Fri 2019-11-22 11:26:30, Greg Kroah-Hartman wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> [ Upstream commit f42f7c283078ce3c1e8368b140e270755b1ae313 ]
>
> Fix up the priority queue to not batch by owner, but by queue, so that
> we allow '1 << priority' elements to be dequeued before switching to
> the next priority queue.
> The owner field is still used to wake up requests in round robin order
> by owner to avoid single processes hogging the RPC layer by loading the
> queues.

> include/linux/sunrpc/sched.h | 2 -
> net/sunrpc/sched.c | 109 +++++++++++++++++------------------
> 2 files changed, 54 insertions(+), 57 deletions(-)

While this might improve things, it is not fixing a serious bug.

Plus, it is over limit for stable.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]