From: Torsten Duwe <duwe@suse.de>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: KASAN_INLINE && patchable-function-entry
Date: Fri, 22 Nov 2019 10:27:54 +0100 [thread overview]
Message-ID: <20191122102754.5a007f66@blackhole> (raw)
In-Reply-To: <20191121183630.GA3668@lakrids.cambridge.arm.com>
Hi Mark!
On Thu, 21 Nov 2019 18:36:32 +0000
Mark Rutland <mark.rutland@arm.com> wrote:
[...]
> Was it intended that -fpatachable-function-entry behaved differently
> from -pg in this regard?
No way! I tried to model it as closely as possible along the established
instrumentation mechanism(s).
> Is this likely to be problematic for other users?
I don't think "likely" is the right word here. "rare" would be even
worse. One corner case is more than enough.
> Are there other implicitly-generated functions we need to look out for
> here, for which this would be a problem?
>
> It looks like this also applies to __attribute__((naked)) on ARM,
IMHO gcc should instrument neither implicitly-generated nor naked
functions in this way. Anybody with reasonable objections please speak
up now.
I'd call it a gcc bug; but it may take a few days...
Torsten
prev parent reply other threads:[~2019-11-22 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 18:36 KASAN_INLINE && patchable-function-entry Mark Rutland
2019-11-21 19:27 ` Steven Rostedt
2019-11-22 11:32 ` Mark Rutland
2019-11-22 11:35 ` Mark Rutland
2019-11-22 9:27 ` Torsten Duwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122102754.5a007f66@blackhole \
--to=duwe@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox