From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Wandun <chenwandun@huawei.com>
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] {tty: serial, nand: onenand}: remove variable 'ufstat' set but not used
Date: Fri, 22 Nov 2019 12:38:59 +0100 [thread overview]
Message-ID: <20191122113859.GA2026910@kroah.com> (raw)
In-Reply-To: <62b2cfc1-416c-f7c7-3029-6dd7ad12ea46@huawei.com>
On Fri, Nov 22, 2019 at 07:33:47PM +0800, Chen Wandun wrote:
>
>
> On 2019/11/22 19:14, Greg KH wrote:
> > On Fri, Nov 22, 2019 at 07:12:39PM +0800, Chen Wandun wrote:
> > > Fixes gcc '-Wunused-but-set-variable' warning:
> > >
> > > drivers/tty/serial/samsung_tty.c: In function s3c24xx_serial_rx_chars_dma:
> > > drivers/tty/serial/samsung_tty.c:549:24: warning: variable ufstat set but not used [-Wunused-but-set-variable]
> > >
> > > Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> >
> > Your subject line is really odd, can you please fix that up and resend?
> I check the git log of drivers/tty/serial/samsung_tty.c,
> it seem like the subject line should be:
> {tty: serial, nand: onenand}: samsung: remove variable 'ufstat' set but not used
>
> Is that OK?
No. What does this patch have to do with nand?
That was from a previous patch that modified two drivers at once. You
are not touching the nand driver.
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-22 11:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 11:12 [PATCH] {tty: serial, nand: onenand}: remove variable 'ufstat' set but not used Chen Wandun
2019-11-22 11:14 ` Greg KH
2019-11-22 11:33 ` Chen Wandun
2019-11-22 11:38 ` Greg KH [this message]
2019-11-22 12:04 ` [PATCH v2] tty: serial: samsung: " Chen Wandun
2019-11-22 12:08 ` Jiri Slaby
2019-11-22 14:13 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122113859.GA2026910@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chenwandun@huawei.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox