From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7267AC33C9E for ; Fri, 22 Nov 2019 19:51:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CEC420726 for ; Fri, 22 Nov 2019 19:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574452265; bh=2a4Arq1cQT5fjUZDzAr7jV7YvQfvKlgMRyQqYIyYUY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NslCyRgHG+jH/UPPFgHigY+balO8kPftdqxXw7NAm0+3r1C2e7DWruddQGbyxu5PD AX3fb8/6978dWbcvP3/NyBjli74RTPD+p900ADrSbyyTxXRkB9+FBG3dQMfdYnS9Mr oPvTWaooqQllX5/1BRbsoBtou0X7EtJo4TLyneO4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbfKVTuR (ORCPT ); Fri, 22 Nov 2019 14:50:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:50790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbfKVTuL (ORCPT ); Fri, 22 Nov 2019 14:50:11 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7720520731; Fri, 22 Nov 2019 19:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574452211; bh=2a4Arq1cQT5fjUZDzAr7jV7YvQfvKlgMRyQqYIyYUY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PgzV3nHDHMTBLrjzWiCrwBjfa2PbAPBO+asMYclAyOE/i4Fp1/phxXQR+ig4pkuV2 AEunMBmkAVX+FyB02oKHHJu6oLkOKCTK9Iqj7BQOVe+Owz6LbFWRVMfybYTG26dBrU m+JRfGyRAjNnMorlQuWCVTDM3cQ3EvN0KMuTHt4s= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chuhong Yuan , Jens Axboe , Sasha Levin , linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 11/13] rsxx: add missed destroy_workqueue calls in remove Date: Fri, 22 Nov 2019 14:49:56 -0500 Message-Id: <20191122194958.24926-11-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122194958.24926-1-sashal@kernel.org> References: <20191122194958.24926-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit dcb77e4b274b8f13ac6482dfb09160cd2fae9a40 ] The driver misses calling destroy_workqueue in remove like what is done when probe fails. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/rsxx/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 34997df132e24..6beafaa335c71 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -1025,8 +1025,10 @@ static void rsxx_pci_remove(struct pci_dev *dev) cancel_work_sync(&card->event_work); + destroy_workqueue(card->event_wq); rsxx_destroy_dev(card); rsxx_dma_destroy(card); + destroy_workqueue(card->creg_ctrl.creg_wq); spin_lock_irqsave(&card->irq_lock, flags); rsxx_disable_ier_and_isr(card, CR_INTR_ALL); -- 2.20.1