Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505.

Rob Herring
2019-11-22T23:57:48Z

On Fri, Nov 15, 2019 at 05:52:19PM +0800, allen wrote:
> From: Allen Chen <allen.chen@ite.com.tw>
>
> Add a DT binding documentation for IT6505.
>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
> .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt

Please make this a DT schema. See
Documentation/devicetree/writing-schema.rst.

> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> new file mode 100644
> index 00000000..72da0c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> @@ -0,0 +1,28 @@
> +iTE it6505 DP bridge bindings
> +
> +Required properties:
> + - compatible: "ite,it6505"
> + - reg: i2c address of the bridge
> + - ovdd-supply: I/O voltage
> + - pwr18-supply: Core voltage
> + - interrupts: interrupt specifier of INT pin
> + - reset-gpios: gpio specifier of RESET pin
> + - hpd-gpios:
> + Hotplug detect GPIO.
> + Indicates which GPIO should be used for hotplug detection

Indentation is not consistent.

> + - port@[x]: SoC specific port nodes with endpoint definitions as defined
> + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt

You need to define what each port is. With the schema, that will be
'port@0' and 'port@1' properties.

> +
> +Example:
> + dp-bridge@5c {
> + compatible = "ite,it6505";
> + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> + reg = <0x5c>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&it6505_pins>;
> + ovdd-supply = <&mt6358_vsim1_reg>;
> + pwr18-supply = <&it6505_pp18_reg>;
> + reset-gpios = <&pio 179 1>;
> + hpd-gpios = <&pio 9 0>;
> + extcon = <&usbc_extcon>;

Not documented plus it's deprecated.

You're missing ports here and they are required.

Rob