Re: [PATCH v4 09/12] dt-bindings: gpio: wcd934x: Add bindings for gpio

Rob Herring
2019-11-23T00:16:22Z

On Thu, Nov 21, 2019 at 05:05:06PM +0000, Srinivas Kandagatla wrote:
> Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated
> gpio controller to control 5 gpios on the chip. This patch adds
> required device tree bindings for it.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../bindings/gpio/qcom,wcd934x-gpio.yaml | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml

Reviewed-by: Rob Herring <robh@kernel.org>

However, this should be referenced from the main file:

gpio@42:
type: object
allOf:
- $ref: ../gpio/qcom,wcd934x-gpio.yaml#

And better to move the example there to be complete.

Rob