From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Julio Faracco <jcfaracco@gmail.com>,
netdev@vger.kernel.org, Daiane Mendes <dnmendes76@gmail.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler
Date: Sun, 24 Nov 2019 15:03:52 -0800 [thread overview]
Message-ID: <20191124150352.5cab3209@cakuba.netronome.com> (raw)
In-Reply-To: <20191124164411-mutt-send-email-mst@kernel.org>
On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote:
> diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c
> index a4ebd2445eda..8e06e7407854 100644
> --- a/arch/m68k/emu/nfeth.c
> +++ b/arch/m68k/emu/nfeth.c
> @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev)
> return 0;
> }
>
> -static void nfeth_tx_timeout(struct net_device *dev)
> +static void nfeth_tx_timeout(struct net_device *dev, int txqueue)
Given the recent vf ndo problems, I wonder if it's worth making the
queue id unsigned from the start? Since it's coming from the stack
there should be no range checking required, but also signed doesn't
help anything so why not?
> {
> dev->stats.tx_errors++;
> netif_wake_queue(dev);
next prev parent reply other threads:[~2019-11-24 23:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 1:36 [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler Julio Faracco
2019-11-22 10:31 ` Michael S. Tsirkin
2019-11-22 12:59 ` Julio Faracco
2019-11-22 13:53 ` Michael S. Tsirkin
2019-11-23 22:33 ` Julio Faracco
2019-11-24 10:52 ` Michael S. Tsirkin
2019-11-24 15:05 ` Michael S. Tsirkin
2019-11-24 21:48 ` Michael S. Tsirkin
2019-11-24 23:03 ` Jakub Kicinski [this message]
2019-11-24 23:18 ` Michael S. Tsirkin
2019-11-24 23:29 ` Michael S. Tsirkin
2019-11-24 23:37 ` Jakub Kicinski
2019-11-25 8:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124150352.5cab3209@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=dnmendes76@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcfaracco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox