From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA88C43215 for ; Tue, 26 Nov 2019 00:13:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 954E02084D for ; Tue, 26 Nov 2019 00:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574727229; bh=Ghi0o1W7Texj6/vA95rjw/U9xU6fBO4BiaunkR+ET00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QGQ0PlmVE0ZzCOsgO4z1XqkL5D1zalH+VhtQQtO8BmqozHxpx9p4VWD8mHCD3WknI Ds7Alq/mW5XTVv4+QqduJAQgKfh+tzs4aRa1amWIyMgztDxHydW/4BU5++zDyMSUoW rg2gpHGbcaARR7qopRH57JqVNrFb3AUY09spaNlw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbfKZANs (ORCPT ); Mon, 25 Nov 2019 19:13:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:54984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbfKZANs (ORCPT ); Mon, 25 Nov 2019 19:13:48 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19509206BF; Tue, 26 Nov 2019 00:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574727228; bh=Ghi0o1W7Texj6/vA95rjw/U9xU6fBO4BiaunkR+ET00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V8LdhQwwiV870veffhEcl+cftjI9P3Dkew+GJqVy8Ip7sFgy7ApNyOoPEaUyPyVO+ 7r/TOMw2s9TPJPas9B4dFKS7qEAkwh0LMTy/BhRnER6NbTDAJEzlVLudc+QF2td+0o Jl3g0gwsFNADsVHSu8oTIZiP4H+QJPMghIwDmCXA= Date: Tue, 26 Nov 2019 09:13:45 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH v3 1/4] selftests/ftrace: Fix to check the existence of set_ftrace_filter Message-Id: <20191126091345.e2eb722e2939864eeb01bc7e@kernel.org> In-Reply-To: <20191125094445.03d0c8df@gandalf.local.home> References: <157466501169.21973.31401747181477687.stgit@devnote2> <157466502067.21973.8795718044691377192.stgit@devnote2> <20191125094445.03d0c8df@gandalf.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Nov 2019 09:44:45 -0500 Steven Rostedt wrote: > On Mon, 25 Nov 2019 15:57:00 +0900 > Masami Hiramatsu wrote: > > > If we run ftracetest on the kernel with CONFIG_DYNAMIC_FTRACE=n, > > there is no set_ftrace_filter and all test cases are failed, > > because reset_ftrace_filter returns an error. > > Let's check whether set_ftrace_filter exists and remove redundant > > set_ftrace_filter from initialize_ftrace(). > > > > Signed-off-by: Masami Hiramatsu > > --- > > tools/testing/selftests/ftrace/test.d/functions | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions > > index 86986c4bba54..19d288cdf336 100644 > > --- a/tools/testing/selftests/ftrace/test.d/functions > > +++ b/tools/testing/selftests/ftrace/test.d/functions > > @@ -46,6 +46,9 @@ reset_events_filter() { # reset all current setting filters > > } > > > > reset_ftrace_filter() { # reset all triggers in set_ftrace_filter > > + if [ ! -f set_ftrace_filter ]; then > > + return 0 > > + fi > > echo > set_ftrace_filter > > grep -v '^#' set_ftrace_filter | while read t; do > > tr=`echo $t | cut -d: -f2` > > @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state > > disable_events > > [ -f set_event_pid ] && echo > set_event_pid > > [ -f set_ftrace_pid ] && echo > set_ftrace_pid > > - [ -f set_ftrace_filter ] && echo | tee set_ftrace_* > > The above should be changed to: > > [ -f set_ftrace_notrace ] && echo > set_ftrace_notrace Ah, good point! I think that should be done by another patch, since it will improve ftracetest. Thank you, > > -- Steve > > > > [ -f set_graph_function ] && echo | tee set_graph_* > > [ -f stack_trace_filter ] && echo > stack_trace_filter > > [ -f kprobe_events ] && echo > kprobe_events > -- Masami Hiramatsu