From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A671C432C3 for ; Tue, 26 Nov 2019 11:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43EF920748 for ; Tue, 26 Nov 2019 11:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574766986; bh=4mYzBFVTXq8hw+3r8N+z0fI4ZJgWTjorxfPhcFmIuzg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ic31d5FZjB/pzyOJHEYSuF1pOsF8PWPObWofXSavsTwB875SFc8CDzF/40S440QbA IOhQcumUxFVITK3W+SlBRQL643aUvMcqdAbVCSWUoe8aFRsxRdFzZLaKgHrMYKnxka 18b2WwDkGnHmOid5k7MKyjcKEbBj1GsQu/b4y8Xg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728052AbfKZLQZ (ORCPT ); Tue, 26 Nov 2019 06:16:25 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38104 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfKZLQY (ORCPT ); Tue, 26 Nov 2019 06:16:24 -0500 Received: by mail-wr1-f65.google.com with SMTP id i12so22028199wro.5; Tue, 26 Nov 2019 03:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mPsIQyZB05XA1geV+/a9mGk6poY26Jzmyx/vRU1WfpY=; b=CvVd5h8yRpWWCZspKyZ2Geub44N8W7U4Jhjye1wj0+gjwAtkOVVmcul2n5Td6FtIOl TYG086TBeCaeOdVzPpwKhwlLc4pXmhKLeWtbE6m/dAKdho1uQ2gr6EZUmN0OfCnHu7vA CkekA1Jm7ugM9uREG/GBYK687qdaWRWRkE+2whjefu8rgH7tRkaaT/cLei9WaenddzQB YDNEo0bfRrPSjq0dSg9yxZszaBpoL3x1/rChO+3ehiBgMCnr9nBa16a76NKGQ4BuO449 +5/bTc4kSISupGE5hditCGRORIPgm4bURLWXT4/8PYFGt4EyUpjU1VnqY7G7PQD752dr 4Cxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mPsIQyZB05XA1geV+/a9mGk6poY26Jzmyx/vRU1WfpY=; b=JZ31AVKIzLzaf/WndVNvbu0QnVoNkZQEL6ASaOVoji4KakROAMs2n+xtWjOk9vtnW0 UpjBnOukcqvhYKXccEOmDqh89qH04T4IdffXwD5Lo/CtD2PxEtrphXJ5T4luLmeXmsK7 zJ962Tede+pXbS4bY9uw264dSu2lpP7Kc4U9r1QhnQYCVGRx4ud6HmZdfxq8hSUyo+Ax oyjHwxKq7RuC8a43lhn7ijKilPO0RPaRe+T6Ff+qzMGdYDIx5ToFPHmr31dwLc/qLHoq lJ2Z3otrgkk44+nha6PD2Iez39ueBucyDcSgivyuBUvoss3WLPDB5teyhicaANUirR4N 5zZQ== X-Gm-Message-State: APjAAAXXxSAfyYSHx2u8PBj9b23INda3kNbLaHxTbxG+8Ogadccl65ab pXGyeajJE0lc4+a46GWUl8c= X-Google-Smtp-Source: APXvYqxSB1tYKQQzsIwE/RCW4zstGtQNypAFngwnyjSt5EMF0PfBQcHF962Sesm4cfpD/IFXIDsxsQ== X-Received: by 2002:adf:ef49:: with SMTP id c9mr16155700wrp.292.1574766982078; Tue, 26 Nov 2019 03:16:22 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id b14sm2692135wmj.18.2019.11.26.03.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 03:16:21 -0800 (PST) Date: Tue, 26 Nov 2019 12:16:18 +0100 From: Ingo Molnar To: Sean Christopherson Cc: Pavel Machek , "Rafael J. Wysocki" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Len Brown , Tony Luck , Fenghua Yu , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Steven Rostedt , Ard Biesheuvel , Darren Hart , Andy Shevchenko , Nadav Amit , "VMware, Inc." , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 11/12] ACPI/sleep: Convert acpi_wakeup_address into a function Message-ID: <20191126111618.GA28423@gmail.com> References: <20191119002121.4107-1-sean.j.christopherson@intel.com> <20191119002121.4107-12-sean.j.christopherson@intel.com> <7338293.UcAxln0NAJ@kreacher> <20191125104803.v6goacte2vjakx64@ucw.cz> <20191125170034.GB12178@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125170034.GB12178@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sean Christopherson wrote: > On Mon, Nov 25, 2019 at 11:48:03AM +0100, Pavel Machek wrote: > > > On Tuesday, November 19, 2019 1:21:20 AM CET Sean Christopherson wrote: > > > > Convert acpi_wakeup_address from a raw variable into a function so that > > > > x86 can wrap its dereference of the real mode boot header in a function > > > > instead of broadcasting it to the world via a #define. This sets the > > > > stage for a future patch to move the definition of acpi_wakeup_address() > > > > out of asm/acpi.h and thus break acpi.h's dependency on asm/realmode.h. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Sean Christopherson > > > > > > Acked-by: Rafael J. Wysocki > > > > > > > --- a/drivers/acpi/sleep.c > > > > +++ b/drivers/acpi/sleep.c > > > > @@ -63,9 +63,9 @@ static int acpi_sleep_prepare(u32 acpi_state) > > > > #ifdef CONFIG_ACPI_SLEEP > > > > /* do we have a wakeup address for S2 and S3? */ > > > > if (acpi_state == ACPI_STATE_S3) { > > > > - if (!acpi_wakeup_address) > > > > + if (!acpi_wakeup_address()) > > > > return -EFAULT; > > > > - acpi_set_waking_vector(acpi_wakeup_address); > > > > + acpi_set_waking_vector(acpi_wakeup_address()); > > > > > > > > You might want to store result in a variable... especially since you are > > turning inline function into real one in a next patch. > > > > And maybe function should be called get_acip_wakeup_address or > > something? This way it is easy to mistake actual wakeup address from > > function that gets it... > > Agreed on both counts. > > > Ingo, > > Would you prefer a v2 of the entire series (with Acks and removal of Fixes), > or a v2 that includes only the last two patches? Yep, that would be handy. I have them committed to tip:core/headers, but haven't sent it to Linus yet, and can redo that all with these improvements. Thanks, Ingo