From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB0FC432C0 for ; Tue, 26 Nov 2019 17:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0F692075C for ; Tue, 26 Nov 2019 17:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574790654; bh=nZpd9q5SU3HFqSPagqBPYxJM48oxzd+k39bvp0A4HI4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c9cjl99dpZRuxlvAUQdAmAPL50mgfYxR9ZGntgqebHpdCPQOto/FaLH+7ZZI61Hih 3nlnJCUs1hWN9Lc25JmbbFDZKmN8yiejE/FFEnV2ZvbmMIcKvWrIjAHFWaDMvzMC2K MF6rjlKrcDazzEt86/Y7KrDnVQ3fXtL6oE7hCqgU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbfKZRuo (ORCPT ); Tue, 26 Nov 2019 12:50:44 -0500 Received: from foss.arm.com ([217.140.110.172]:37558 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfKZRun (ORCPT ); Tue, 26 Nov 2019 12:50:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E74AB30E; Tue, 26 Nov 2019 09:50:42 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CC813F52E; Tue, 26 Nov 2019 09:50:42 -0800 (PST) Date: Tue, 26 Nov 2019 17:50:40 +0000 From: Mark Brown To: Adam Thomson Cc: Sebastian Reichel , Support Opensource , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "kernel@collabora.com" Subject: Re: [PATCHv2 6/6] ASoC: da7213: Add default clock handling Message-ID: <20191126175040.GD4205@sirena.org.uk> References: <20191120152406.2744-1-sebastian.reichel@collabora.com> <20191120152406.2744-7-sebastian.reichel@collabora.com> <20191126170841.GC4205@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eheScQNz3K90DVRs" Content-Disposition: inline In-Reply-To: X-Cookie: Where's SANDY DUNCAN? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eheScQNz3K90DVRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 26, 2019 at 05:39:45PM +0000, Adam Thomson wrote: > On 26 November 2019 17:09, Mark Brown wrote: > > If we're special casing simple-card we're doing it wrong - there's > > nothing stopping any other machine driver behaving in the same way. > Ok, what's being proposed here is for the codec to automatically control = the PLL > rather than leaving it to the machine driver as is the case right now. In= the > possible scenario where this is done using a card level widget to enable/= disable Wasn't the proposal to add a new mode where the machine driver *could* choose to delgate PLL selection to the CODEC driver rather than do so unconditionally? =20 > the PLL we will conflict with that using the current suggested approach f= or the > da7213 driver, albeit with no real consequence other than configuring the= PLL > twice the first time a stream is started. It's a case of how to determine= who's > in control of the PLL here; machine driver or codec? The patch looked like the idea was that as soon as the machine driver configures the PLL the CODEC driver will stop touching it which looked like a reasonable way of doing it, you could also do it with an explicit SYSCLK value (which would have to be 0 for generic machine drivers to pick it up) but this works just as well and may even be better. Perhaps I misread it though. --eheScQNz3K90DVRs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3dZfAACgkQJNaLcl1U h9CwfAf/YV/EIozE9EzDMFY5bhh24HCl54wOPeRj11gAdUc9Dgos5WcUBUp1OKGF fMWwffNUQQ6pttjnObQRNpgbEYALQbgmriiDqKa6l7m/jBgm0vaXtF+rdbyHEt7Z VGEZcUDDUYjL3lYLHpmCMIxuON1NceLHNn6UjNWc3ukHuKOZTDVKANSoAiskfvuH dpcZX/A6I71lUtLq54+uVGh28k7/5cOL2sE/syHjQyA25LcH71hjFVhaByUcx8EC AjV8phIVnDYDzwAQhrz0MfXCySpsaq0oPNWHkr9S4d4RZvVaqI5DFVVRGxUivZOM auolGphSGFR7UvpNFLu9qItUxlTZxA== =SdHM -----END PGP SIGNATURE----- --eheScQNz3K90DVRs--