Re: [PATCH] libbpf: Fix up generation of bpf_helper_defs.h

Alexei Starovoitov
2019-11-28T00:59:30Z

On Wed, Nov 27, 2019 at 4:50 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Take it as one, I think it's what should have been in the cset it is fixing, that way no breakage would have happened.

Ok. I trimmed commit log and applied here:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=1fd450f99272791df8ea8e1b0f5657678e118e90

What about your other fix and my suggestion there?
(__u64) cast instead of PRI ?
We do this already in two places:
libbpf.c: shdr_idx, (__u64)sym->st_value);
libbpf.c: (__u64)sym.st_value, GELF_ST_TYPE(sym.st_info),