Re: [PATCH] of: overlay: add_changeset_property() memory leak

Vincent Whitchurch
2019-11-25T15:17:51Z

On Thu, Nov 21, 2019 at 08:20:21PM +0100, Frank Rowand wrote:
> On 11/21/19 1:16 PM, frowand.list@gmail.com wrote:
> > From: Frank Rowand <frank.rowand@sony.com>
> >
> > No changeset entries are created for #address-cells and #size-cells
> > properties, but the duplicated properties are never freed. This
> > results in a memory leak which is detected by kmemleak:
> >
> > unreferenced object 0x85887180 (size 64):
> > backtrace:
> > kmem_cache_alloc_trace+0x1fb/0x1fc
> > __of_prop_dup+0x25/0x7c
> > add_changeset_property+0x17f/0x370
> > build_changeset_next_level+0x29/0x20c
> > of_overlay_fdt_apply+0x32b/0x6b4
> > ...
> >
> > Fixes: 6f75118800acf77f8 ("of: overlay: validate overlay properties #address-cells and #size-cells")
> > Reported-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>
> Can you please check whether this patch fixes the memleak that you
> found and fixed in "[PATCH 1/2] of: overlay: fix properties memory leak"?

Tested-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

Thanks.