From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DA0C432C0 for ; Tue, 26 Nov 2019 19:37:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D39BA2073F for ; Tue, 26 Nov 2019 19:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbfKZTho (ORCPT ); Tue, 26 Nov 2019 14:37:44 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:50594 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfKZTho (ORCPT ); Tue, 26 Nov 2019 14:37:44 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A99EE20053; Tue, 26 Nov 2019 20:37:41 +0100 (CET) Date: Tue, 26 Nov 2019 20:37:40 +0100 From: Sam Ravnborg To: Mihail Atanassov Cc: "dri-devel@lists.freedesktop.org" , David Airlie , "linux-kernel@vger.kernel.org" , nd , Vincent Abriou Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init() Message-ID: <20191126193740.GC2044@ravnborg.org> References: <20191126131541.47393-1-mihail.atanassov@arm.com> <20191126131541.47393-29-mihail.atanassov@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191126131541.47393-29-mihail.atanassov@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7CQSdrXTAAAA:8 a=6lCv3_9TmdkNs-__4ugA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mihail. On Tue, Nov 26, 2019 at 01:16:26PM +0000, Mihail Atanassov wrote: > No functional change. > > Signed-off-by: Mihail Atanassov > --- > drivers/gpu/drm/sti/sti_dvo.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index 68289b0b063a..20a3956b33bc 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -462,9 +462,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -ENOMEM; > > - bridge->driver_private = dvo; > - bridge->funcs = &sti_dvo_bridge_funcs; > - bridge->of_node = dvo->dev.of_node; > + drm_bridge_init(bridge, &dvo->dev, &sti_dvo_bridge_funcs, NULL, dvo); > drm_bridge_add(bridge); > > err = drm_bridge_attach(encoder, bridge, NULL); I can see from grepping that bridge.driver_private is used in a couple of other files in sti/ Like sti_hdmi.c: bridge->driver_private = hdmi; bridge->funcs = &sti_hdmi_bridge_funcs; drm_bridge_attach(encoder, bridge, NULL); I wonder if a drm_bridge_init() should be added there. I did not look closely - but it looked suspisiously. Sam