From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073F4C432C0 for ; Wed, 27 Nov 2019 12:33:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEE332075C for ; Wed, 27 Nov 2019 12:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574858001; bh=LzYhxJZwT/5cPL9ppG3GIvLklUK/CrB3gpOUIIGf6vg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NapFfDZ5oIqoC4AjKqTIU9JHspltjzWU0050TNj0rW3WbZcWRB9u2D20gCnvnLof4 4Yfr1ksmQfUkmwBDqU+oqxQlSF3J3i1PCEU8GJBlx2FN5q1ke40RPMJ5+bCpsKgxPi wXaJTqCndQWmfnjo6zIQdtkaD1PUX5R10sS8vNMs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbfK0MdV (ORCPT ); Wed, 27 Nov 2019 07:33:21 -0500 Received: from foss.arm.com ([217.140.110.172]:47118 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfK0MdU (ORCPT ); Wed, 27 Nov 2019 07:33:20 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3B9C30E; Wed, 27 Nov 2019 04:33:19 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 70AFC3F6C4; Wed, 27 Nov 2019 04:33:19 -0800 (PST) Date: Wed, 27 Nov 2019 12:33:17 +0000 From: Mark Brown To: Adam Thomson Cc: Sebastian Reichel , Support Opensource , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "kernel@collabora.com" Subject: Re: [PATCHv2 6/6] ASoC: da7213: Add default clock handling Message-ID: <20191127123317.GA4879@sirena.org.uk> References: <20191120152406.2744-1-sebastian.reichel@collabora.com> <20191120152406.2744-7-sebastian.reichel@collabora.com> <20191126170841.GC4205@sirena.org.uk> <20191126175040.GD4205@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: X-Cookie: In the war of wits, he's unarmed. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 27, 2019 at 11:32:54AM +0000, Adam Thomson wrote: > As I said it's a small thing and requires a specific use-case to occur, but > having the PLL configured twice for the very first stream in that scenario > seems messy. Regarding the SYSCLK approach you mention, I'm not clear how that > would work so I'm obviously missing something. If we had some init stage > indication though that auto PLL was required then we're golden. There's a bunch of other drivers using the SYSCLK thing, when you call set_sysclk() they provide a different SYSCLK number if they want to use manual mode. If there's a concern about drivers doing stuff on init you could always ask them to set the PLL during init, even if only briefly. --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3ebQoACgkQJNaLcl1U h9BDaQf/ZAlgmS17icedamvRKebKOojZ+VtpiJMgMsOiLs1eMu10rJm/6XiCT5sh dvPRA9mGno4nal5L/s8UHj3CFPkHSYqPGI/uwY4Gf4Ek2B9cyMHiW3ht1MozjcDH I2QMxZxMhqHCf1p5a8fh+2jlyFfwC8lpluRg57rLT5PTdb27MBbrshYHlPuuxKtk p7U1irpsbnO6iW3CAp9N8kIc996SItJ7230JQCHXdLJ0X773ekOLQTSb5Ypn0Y/f kD+NRNoggRWJ70XZqm3DwMQRdGIW33IWR/nS+W0ncP93hfneMjYpp4byZ+BGWOwy CozlfXK15fWw/kq+9Gw1LGWv9CKSxw== =thrJ -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--