Re: [PATCH v4 01/19] x86/msr-index: Clean up bit defines for IA32_FEATURE_CONTROL MSR

Sean Christopherson
2019-12-12T17:48:07Z

On Thu, Dec 12, 2019 at 10:25:09AM +0100, Borislav Petkov wrote:
> On Mon, Dec 02, 2019 at 11:06:33AM -0800, Sean Christopherson wrote:
> > Argh, flat out missed this when doing search and replace.
>
> There are more. What always works reliably for me is git grep:
>
> $ git grep MSR_IA32_FEATURE_CONTROL
> drivers/idle/intel_idle.c:1287: rdmsrl(MSR_IA32_FEATURE_CONTROL, msr);
> tools/arch/x86/include/asm/msr-index.h:561:#define MSR_IA32_FEATURE_CONTROL 0x0000003a
> tools/power/x86/turbostat/turbostat.c:4502: if (!get_msr(base_cpu, MSR_IA32_FEATURE_CONTROL, &msr))
> tools/power/x86/turbostat/turbostat.c:4503: fprintf(outf, "cpu%d: MSR_IA32_FEATURE_CONTROL: 0x%08llx (%sLocked %s)\n",
> tools/testing/selftests/kvm/include/x86_64/processor.h:771:#define MSR_IA32_FEATURE_CONTROL 0x0000003a
> tools/testing/selftests/kvm/lib/x86_64/vmx.c:162: feature_control = rdmsr(MSR_IA32_FEATURE_CONTROL);
> tools/testing/selftests/kvm/lib/x86_64/vmx.c:164: wrmsr(MSR_IA32_FEATURE_CONTROL, feature_control | required);
>
> those additional ones won't break the build but it is perhaps worth
> unifying them all since we're at it, anyway.

I caught all the tools updates and addressed them in patch 03/19, "tools
arch x86: Sync msr-index.h from kernel sources". Do you want those changes
folded into the rename itself?