From: Greg KH <gregkh@linuxfoundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 0/3] debugfs: introduce debugfs_create_single/seq[,_data]
Date: Fri, 29 Nov 2019 15:21:10 +0100 [thread overview]
Message-ID: <20191129142110.GA3708031@kroah.com> (raw)
In-Reply-To: <20191129092752.169902-1-wangkefeng.wang@huawei.com>
On Fri, Nov 29, 2019 at 05:27:49PM +0800, Kefeng Wang wrote:
> Like proc_create_single/seq[,_data] in procfs, we could provide similar debugfs
> helper to reduce losts of boilerplate code.
>
> debugfs_create_single[,_data]
> creates a file in debugfs with the extra data and a seq_file show callback.
> debugfs_create_seq[,_data]
> creates a file in debugfs with the extra data and a seq_operations.
>
> There is a object dynamically allocated in the helper, which is used to store
> extra data, we need free it when remove the debugfs file.
>
> If the change is acceptable, we could change the caller one by one.
I would like to see a user of this and how you would convert it, in
order to see if this is worth it or not.
When you redo this series, can you add that to the end of it?
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-29 14:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 9:27 [PATCH next 0/3] debugfs: introduce debugfs_create_single/seq[,_data] Kefeng Wang
2019-11-29 9:27 ` [PATCH next 1/3] debugfs: Provide debugfs_[set|clear|test]_lowest_bit() Kefeng Wang
2019-11-29 9:27 ` [PATCH next 2/3] debugfs: introduce debugfs_create_single[,_data] Kefeng Wang
2019-12-03 8:38 ` Dan Carpenter
2019-12-03 9:02 ` [kbuild-all] " Rong Chen
2019-12-03 9:32 ` Dan Carpenter
2019-11-29 9:27 ` [PATCH next 3/3] debugfs: introduce debugfs_create_seq[,_data] Kefeng Wang
2019-11-29 14:22 ` Greg KH
2019-11-29 15:03 ` Kefeng Wang
2019-11-29 22:16 ` Greg KH
2019-11-29 14:21 ` Greg KH [this message]
2019-11-29 15:16 ` [PATCH next 0/3] debugfs: introduce debugfs_create_single/seq[,_data] Kefeng Wang
2019-11-29 22:19 ` Greg KH
2019-11-29 22:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129142110.GA3708031@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox