From: Davidlohr Bueso <dave@stgolabs.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
mceier@gmail.com, kernel test robot <rong.a.chen@intel.com>,
Davidlohr Bueso <dbueso@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, "Kenneth R. Crudup" <kenny@panix.com>
Subject: Re: [PATCH] x86/pat: Fix off-by-one bugs in interval tree search
Date: Sun, 1 Dec 2019 09:01:15 -0800 [thread overview]
Message-ID: <20191201170115.molqadzebqo2sldu@linux-p48b> (raw)
In-Reply-To: <20191201144947.GA4167@gmail.com>
On Sun, 01 Dec 2019, Ingo Molnar wrote:
>So the correct parameter to use in the interval tree searches is not
>'end' but 'end-1'.
Yes absolutely, I overlooked this in the final conversion. Going through some
older conversions, I had this end-1 at one point. Lookups need half-open intervals,
consistent with what memtype_interval_end() does.
[...]
>Patch is only lightly tested, so take care. (Patch is emphatically not
>signed off yet, because I spent most of the day on this and I don't yet
>trust my fix - all of the affected sites need to be reviewed more
>carefully.)
As a general note, this is rather consistent with how all interval-tree
users that need [a,b) nodes use the api.
Thanks,
Davidlohr
next prev parent reply other threads:[~2019-12-01 17:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 0:53 [x86/mm/pat] 8d04a5f97a: phoronix-test-suite.glmark2.0.score -23.7% regression kernel test robot
2019-11-30 20:23 ` Mariusz Ceier
2019-11-30 21:27 ` Davidlohr Bueso
2019-11-30 22:08 ` Mariusz Ceier
2019-11-30 22:35 ` Linus Torvalds
2019-12-01 10:46 ` Ingo Molnar
2019-12-01 14:49 ` [PATCH] x86/pat: Fix off-by-one bugs in interval tree search Ingo Molnar
2019-12-01 16:09 ` Mariusz Ceier
2019-12-01 19:53 ` Ingo Molnar
2019-12-01 16:42 ` Kenneth R. Crudup
2019-12-01 17:01 ` Davidlohr Bueso [this message]
2019-12-01 17:08 ` Kenneth R. Crudup
2019-12-01 19:55 ` Ingo Molnar
2019-12-01 20:09 ` Kenneth R. Crudup
2019-12-01 20:30 ` Ingo Molnar
2019-12-01 20:04 ` [tip: x86/urgent] x86/mm/pat: " tip-bot2 for Ingo Molnar
2019-12-02 8:31 ` [PATCH] x86/pat: " Rong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191201170115.molqadzebqo2sldu@linux-p48b \
--to=dave@stgolabs.net \
--cc=bp@alien8.de \
--cc=dbueso@suse.de \
--cc=kenny@panix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=mceier@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rong.a.chen@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox