linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "Kenneth R. Crudup" <kenny@panix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	mceier@gmail.com, Davidlohr Bueso <dave@stgolabs.net>,
	kernel test robot <rong.a.chen@intel.com>,
	Davidlohr Bueso <dbueso@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org
Subject: Re: [PATCH] x86/pat: Fix off-by-one bugs in interval tree search
Date: Sun, 1 Dec 2019 20:55:21 +0100	[thread overview]
Message-ID: <20191201195521.GC3615@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1912010906030.2748@hp-x360n>


* Kenneth R. Crudup <kenny@panix.com> wrote:

> 
> On Sun, 1 Dec 2019, Ingo Molnar wrote:
> 
> > So it would be nice if everyone who is seeing this bug could test the
> > patch below against Linus's latest tree - does it fix the regression?
> 
> The patch fixes the issue for me.

Great, thanks!

> > If not then please send the before/after dump of
> > /sys/kernel/debug/x86/pat_memtype_list - and even if it works please send
> > the dumps so we can double check it all.
> 
> I don't have the "before patch" (but could if it is absolutely needed) but
> here's the "after patch":

> uncached-minus @ 0xfed91000-0xfed92000
> uncached-minus @ 0xff340000-0xff341000
> write-combining @ 0x4000000000-0x4010000000
> uncached-minus @ 0x4010000000-0x4010001000

I believe this is the region that caused the problem, the 0x4010000000 
'end' address of the WC region is the same as the 0x4010000000 'start' 
address of the UC- region that follows it.

> write-combining @ 0x604a800000-0x604b000000
> uncached-minus @ 0x604b100000-0x604b110000

This WC region was probably unaffected by the bug.

Thanks,

	Ingo

  reply	other threads:[~2019-12-01 19:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  0:53 [x86/mm/pat] 8d04a5f97a: phoronix-test-suite.glmark2.0.score -23.7% regression kernel test robot
2019-11-30 20:23 ` Mariusz Ceier
2019-11-30 21:27   ` Davidlohr Bueso
2019-11-30 22:08     ` Mariusz Ceier
2019-11-30 22:35       ` Linus Torvalds
2019-12-01 10:46         ` Ingo Molnar
2019-12-01 14:49           ` [PATCH] x86/pat: Fix off-by-one bugs in interval tree search Ingo Molnar
2019-12-01 16:09             ` Mariusz Ceier
2019-12-01 19:53               ` Ingo Molnar
2019-12-01 16:42             ` Kenneth R. Crudup
2019-12-01 17:01             ` Davidlohr Bueso
2019-12-01 17:08             ` Kenneth R. Crudup
2019-12-01 19:55               ` Ingo Molnar [this message]
2019-12-01 20:09                 ` Kenneth R. Crudup
2019-12-01 20:30                   ` Ingo Molnar
2019-12-01 20:04             ` [tip: x86/urgent] x86/mm/pat: " tip-bot2 for Ingo Molnar
2019-12-02  8:31             ` [PATCH] x86/pat: " Rong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191201195521.GC3615@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=kenny@panix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@lists.01.org \
    --cc=mceier@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rong.a.chen@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).