From: Ingo Molnar <mingo@kernel.org>
To: "Kenneth R. Crudup" <kenny@panix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
mceier@gmail.com, Davidlohr Bueso <dave@stgolabs.net>,
kernel test robot <rong.a.chen@intel.com>,
Davidlohr Bueso <dbueso@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org
Subject: Re: [PATCH] x86/pat: Fix off-by-one bugs in interval tree search
Date: Sun, 1 Dec 2019 21:30:58 +0100 [thread overview]
Message-ID: <20191201203058.GA82131@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1912011205350.2748@hp-x360n>
* Kenneth R. Crudup <kenny@panix.com> wrote:
> > > write-combining @ 0x604a800000-0x604b000000
> > > uncached-minus @ 0x604b100000-0x604b110000
>
> > This WC region was probably unaffected by the bug.
>
> For my education, and for completeness' sake, is there a proc/sys entry
> that would tell me which device/module has reserved which PAT region?
Not that I know of :-/
I suspect you could run the attached patch and run:
dmesg | grep -i 'x86/pat'
To see all the ioremap() activities, with a symbolic name of the caller printed.
I'm quite sure 0x604a800000 will be among them, pointing to somewhere
like i915_vma_pin_iomap(), ggtt_init_hw() or ggtt_probe_common() in the
i915 GPU driver?
Another possibility is that this is the FB framebuffer, mapped by
efifb_probe() or so?
Patch is untested though. :-)
Thanks,
Ingo
=================>
arch/x86/mm/ioremap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 1ff9c2030b4f..2f0a4f99471a 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -166,6 +166,8 @@ __ioremap_caller(resource_size_t phys_addr, unsigned long size,
int retval;
void __iomem *ret_addr;
+ printk("# x86/pat: ioremap(%016Lx, %08lx, pcm: %d), caller: %pS\n", phys_addr, size, pcm, caller);
+
/* Don't allow wraparound or zero size */
last_addr = phys_addr + size - 1;
if (!size || last_addr < phys_addr)
next prev parent reply other threads:[~2019-12-01 20:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 0:53 [x86/mm/pat] 8d04a5f97a: phoronix-test-suite.glmark2.0.score -23.7% regression kernel test robot
2019-11-30 20:23 ` Mariusz Ceier
2019-11-30 21:27 ` Davidlohr Bueso
2019-11-30 22:08 ` Mariusz Ceier
2019-11-30 22:35 ` Linus Torvalds
2019-12-01 10:46 ` Ingo Molnar
2019-12-01 14:49 ` [PATCH] x86/pat: Fix off-by-one bugs in interval tree search Ingo Molnar
2019-12-01 16:09 ` Mariusz Ceier
2019-12-01 19:53 ` Ingo Molnar
2019-12-01 16:42 ` Kenneth R. Crudup
2019-12-01 17:01 ` Davidlohr Bueso
2019-12-01 17:08 ` Kenneth R. Crudup
2019-12-01 19:55 ` Ingo Molnar
2019-12-01 20:09 ` Kenneth R. Crudup
2019-12-01 20:30 ` Ingo Molnar [this message]
2019-12-01 20:04 ` [tip: x86/urgent] x86/mm/pat: " tip-bot2 for Ingo Molnar
2019-12-02 8:31 ` [PATCH] x86/pat: " Rong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191201203058.GA82131@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=kenny@panix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=mceier@gmail.com \
--cc=peterz@infradead.org \
--cc=rong.a.chen@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).