From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4F3C432C0 for ; Mon, 2 Dec 2019 23:06:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3927F206F0 for ; Mon, 2 Dec 2019 23:06:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="MDlXD2YW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbfLBXGw (ORCPT ); Mon, 2 Dec 2019 18:06:52 -0500 Received: from mail.skyhub.de ([5.9.137.197]:34576 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfLBXGv (ORCPT ); Mon, 2 Dec 2019 18:06:51 -0500 Received: from zn.tnic (p200300EC2F0AE80079FCF5458EAE7CF0.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:e800:79fc:f545:8eae:7cf0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 831681EC0C25; Tue, 3 Dec 2019 00:06:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1575328010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=i7vZLUOGFxnJFHysBe5Ey42STmSMY9QAcjrh4bfl+ik=; b=MDlXD2YWxexNuARyeqQPTHV4wF911X9Mq9KeasR0YPMtcA7tmzHBavwtE/IstJaGBzUmWv 4YXV7ufP+Q9m8qkP9I5WwkvDwVrCjiedGh0l8HiBx8ivL/hpadLbZeztNF0vAfkPztk4UB 7uYl63TuYxbQrg8RSwtiUCcL1EiH5Os= Date: Tue, 3 Dec 2019 00:06:42 +0100 From: Borislav Petkov To: Fenghua Yu Cc: Thomas Gleixner , Ingo Molnar , H Peter Anvin , Tony Luck , Reinette Chatre , Babu Moger , Andre Przywara , Sai Praneeth Prakhya , Ravi V Shankar , linux-kernel , x86 Subject: Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests Message-ID: <20191202230642.GD32696@zn.tnic> References: <1574901584-212957-1-git-send-email-fenghua.yu@intel.com> <1574901584-212957-2-git-send-email-fenghua.yu@intel.com> <20191128072338.GA17745@zn.tnic> <20191202185334.GA220960@romley-ivt3.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191202185334.GA220960@romley-ivt3.sc.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 02, 2019 at 10:53:35AM -0800, Fenghua Yu wrote: > Babu's major contributions are in v5 where he virtually touched every > patch. He sent out v5 and put Signed-off-by: Babu Moger in each patch: > https://lore.kernel.org/patchwork/cover/1033532/ > > That's why I keep his SOB in v6-v8 in each patch. For that you either need to use Co-developed-by: Babu or state the fact that Babu did contribute to the patches in freetext in the commit messages. As it is now, it is not clear what it means. You could've kept the order from v5 since you took his submission and could've done: Signed-off-by: Fenghua Yu Signed-off-by: Babu Moger Signed-off-by: Fenghua Yu to show you're the author, Babu handled them further and you're sending the patchset now, but the other thing I suggested above is more clear IMO. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette