From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E607C432C0 for ; Mon, 2 Dec 2019 22:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 487BF20722 for ; Mon, 2 Dec 2019 22:15:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="hJ2jxg0G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbfLBWPb (ORCPT ); Mon, 2 Dec 2019 17:15:31 -0500 Received: from mail.andi.de1.cc ([85.214.55.253]:51822 "EHLO mail.andi.de1.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfLBWPb (ORCPT ); Mon, 2 Dec 2019 17:15:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=87DJGgaOP4OR26er35jT2d/3xlEOtUkjxl/DEu2Hv4A=; b=hJ2jxg0GQjdVMV90G3GTon9LzP 71+pbAIhRDz3VxHs5UvWw2oSaW56+b3e9zgmTUTcandElA+kNrbzsnGSsp9BNhIcjj/b9y0gS2U5y 86W+CopAbhsHmyZresdzs0aZ4nRuxZyZc6L6WiVP30w3R1dqcc6NTv1USIjxt/xdoCN8=; Received: from p200300ccff066f001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff06:6f00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibtyV-0008V1-Oz; Mon, 02 Dec 2019 23:15:24 +0100 Date: Mon, 2 Dec 2019 23:15:22 +0100 From: Andreas Kemnade To: "H. Nikolaus Schaller" Cc: Tony Lindgren , Linux-OMAP , arm-soc , Adam Ford , =?UTF-8?B?QW5kcsOp?= Roth , Nishanth Menon , Tero Kristo , Linux Kernel Mailing List , Discussions about the Letux Kernel Subject: Re: [PATCH] ARM: OMAP2+: Fix warnings with broken omap2_set_init_voltage() Message-ID: <20191202231522.5e7fe3f8@aktux> In-Reply-To: <8FFD44DB-73F8-4807-91E1-C97DA8F781BA@goldelico.com> References: <20190924233222.52757-1-tony@atomide.com> <8FFD44DB-73F8-4807-91E1-C97DA8F781BA@goldelico.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Dec 2019 22:09:26 +0100 "H. Nikolaus Schaller" wrote: > Hi Tony, >=20 > > Am 25.09.2019 um 01:32 schrieb Tony Lindgren : > >=20 > > This code is currently unable to find the dts opp tables as ti-cpufreq > > needs to set them up first based on speed binning. > >=20 > > We stopped initializing the opp tables with platform code years ago for > > device tree based booting with commit 92d51856d740 ("ARM: OMAP3+: do not > > register non-dt OPP tables for device tree boot"), and all of mach-omap2 > > is now booting using device tree. > >=20 > > We currently get the following errors on init: > >=20 > > omap2_set_init_voltage: unable to find boot up OPP for vdd_mpu > > omap2_set_init_voltage: unable to set vdd_mpu > > omap2_set_init_voltage: unable to find boot up OPP for vdd_core > > omap2_set_init_voltage: unable to set vdd_core > > omap2_set_init_voltage: unable to find boot up OPP for vdd_iva > > omap2_set_init_voltage: unable to set vdd_iva > >=20 > > Let's just drop the unused code. Nowadays ti-cpufreq should be used to > > to initialize things properly. > >=20 > > Cc: Adam Ford > > Cc: Andr=C3=A9 Roth > > Cc: "H. Nikolaus Schaller" > > Cc: Nishanth Menon > > Cc: Tero Kristo > > Signed-off-by: Tony Lindgren > > --- > >=20 > > Guys, please check and ack if we can really do this to get rid of some > > pointless dmesg -l3 errors without affecting the ongoing cpufreq and > > voltage work. =20 >=20 > unfortunately we did not yet test in combination with the 1GHz OPP > patches for omap3630 (queued for v5.5-rc1) and it appears that this > patch breaks the 1GHz OPP. >=20 > The symptom is that it works fine on a dm3730 with 800MHz rating > but results in spurious kernel panics, stack corruption, virtual memory > failures, OneNAND DMA timeouts etc. on a dm3730 with 1GHz speed grade. >=20 I #if 0'ed the 1Ghz opp and found out that the OneNAND DMA timeouts are independant of 1Ghz. But the result is interesting: With this patch xxd /dev/mtd0 shows only ff without this patch gives content, it is slower. In both cases I see [ 476.533477] omap2-onenand 4000000.onenand: timeout waiting for DMA Regards, Andreas