From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BEBC432C0 for ; Tue, 3 Dec 2019 07:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF11A20684 for ; Tue, 3 Dec 2019 07:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OMyMYL36" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727458AbfLCH2y (ORCPT ); Tue, 3 Dec 2019 02:28:54 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:54154 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727386AbfLCH2y (ORCPT ); Tue, 3 Dec 2019 02:28:54 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xB37O0Ew116400; Tue, 3 Dec 2019 07:28:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=qco2ixbN1TtUc8WP/AJYYaNXEN4NS/EAZ+OClpveUgw=; b=OMyMYL36L/LL3zylLL2mgrPXYqiZx7cZdixsUrr7hadOaKlV+6W+E8WCeGTtHz40Oce2 /grNZL+mb6KW+63B5AfRwayeGwingg+QleUnXQqTOMnCHqX2dvHu9M7bKfgS6MHMJetV nTnk3jw+kRC1pg2uW95ODUnBQ2tL04WVVeMWAt3dhWke5wzJ1oUh7/21gkjgDG1n4l5t hEuOlY8T1mgQE25jx+xQ7L7BViYcNQjaeT/V7swONC9FHt40ucov6nDOqqHdC23jfcgx XhJ/eB0lKHpc5kHIrF44MEKjamY+s+RCxmyM/cf2tuMUAZBvKV4LrS78QCAZY08WUx3M PQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2wkfuu5qgj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Dec 2019 07:28:44 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xB37SRmD158987; Tue, 3 Dec 2019 07:28:43 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2wn8k1waee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Dec 2019 07:28:43 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xB37Sep8007933; Tue, 3 Dec 2019 07:28:40 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 02 Dec 2019 23:28:39 -0800 Date: Tue, 3 Dec 2019 10:28:24 +0300 From: Dan Carpenter To: Colin King Cc: Arnd Bergmann , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i Message-ID: <20191203072824.GA1765@kadam> References: <20191202151352.55139-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202151352.55139-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9459 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912030061 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9459 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912030060 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 02, 2019 at 03:13:52PM +0000, Colin King wrote: > From: Colin Ian King > > The variable i is being initialized with a value that is never > read and it is being updated later with a new value in a for-loop. > The initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/misc/ti-st/st_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c > index 2ae9948a91e1..6255d9b88122 100644 > --- a/drivers/misc/ti-st/st_core.c > +++ b/drivers/misc/ti-st/st_core.c > @@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty) > > static void st_tty_close(struct tty_struct *tty) > { > - unsigned char i = ST_MAX_CHANNELS; > + unsigned char i; > unsigned long flags = 0; I'm surprised that flags doesn't generate a warning as well. regards, dan carpenter