From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Workqueues splat due to ending up on wrong CPU
Date: Tue, 3 Dec 2019 11:06:59 +0100 [thread overview]
Message-ID: <20191203100659.GA2871@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191203095521.GH2827@hirez.programming.kicks-ass.net>
On Tue, Dec 03, 2019 at 10:55:21AM +0100, Peter Zijlstra wrote:
> @@ -1100,6 +1099,12 @@ void cpuhp_online_idle(enum cpuhp_state state)
> if (state != CPUHP_AP_ONLINE_IDLE)
> return;
>
> + /*
> + * Unpark the stopper thread before we start the idle thread; this
s/thread/loop/, _this_ is the idle thread :-)
> + * ensures the stopper is always available.
> + */
> + stop_machine_unpark(smp_processor_id());
> +
> st->state = CPUHP_AP_ONLINE_IDLE;
> complete_ap_thread(st, true);
> }
next prev parent reply other threads:[~2019-12-03 10:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 23:03 Workqueues splat due to ending up on wrong CPU Paul E. McKenney
2019-11-26 18:33 ` Tejun Heo
2019-11-26 22:05 ` Paul E. McKenney
2019-11-27 15:50 ` Paul E. McKenney
2019-11-28 16:18 ` Paul E. McKenney
2019-11-29 15:58 ` Paul E. McKenney
2019-12-02 1:55 ` Paul E. McKenney
2019-12-02 20:13 ` Tejun Heo
2019-12-02 23:39 ` Paul E. McKenney
2019-12-03 10:00 ` Peter Zijlstra
2019-12-03 17:45 ` Paul E. McKenney
2019-12-03 18:13 ` Tejun Heo
2019-12-03 9:55 ` Peter Zijlstra
2019-12-03 10:06 ` Peter Zijlstra [this message]
2019-12-03 15:42 ` Tejun Heo
2019-12-03 16:04 ` Paul E. McKenney
2019-12-04 20:11 ` Paul E. McKenney
2019-12-05 10:29 ` Peter Zijlstra
2019-12-05 10:32 ` Peter Zijlstra
2019-12-05 14:48 ` Paul E. McKenney
2019-12-06 3:19 ` Paul E. McKenney
2019-12-06 18:52 ` Paul E. McKenney
2019-12-06 22:00 ` Paul E. McKenney
2019-12-09 18:59 ` Paul E. McKenney
2019-12-10 9:08 ` Peter Zijlstra
2019-12-10 22:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203100659.GA2871@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox