From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495C7C432C0 for ; Tue, 3 Dec 2019 18:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DD6E206DF for ; Tue, 3 Dec 2019 18:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727217AbfLCSXO (ORCPT ); Tue, 3 Dec 2019 13:23:14 -0500 Received: from mga17.intel.com ([192.55.52.151]:3696 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbfLCSXO (ORCPT ); Tue, 3 Dec 2019 13:23:14 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 10:23:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,274,1571727600"; d="scan'208";a="242509095" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by fmsmga002.fm.intel.com with ESMTP; 03 Dec 2019 10:23:13 -0800 Date: Tue, 3 Dec 2019 10:27:56 -0800 From: Jacob Pan To: Joe Perches Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , Lu Baolu , David Woodhouse , "Tian, Kevin" , Raj Ashok , Yi Liu , Eric Auger , "Mehta, Sohil" , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v5 8/8] iommu/vt-d: Misc macro clean up for SVM Message-ID: <20191203102756.73611444@jacob-builder> In-Reply-To: References: <1575316709-54903-1-git-send-email-jacob.jun.pan@linux.intel.com> <1575316709-54903-9-git-send-email-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Dec 2019 12:10:45 -0800 Joe Perches wrote: > On Mon, 2019-12-02 at 11:58 -0800, Jacob Pan wrote: > > Use combined macros for_each_svm_dev() to simplify SVM device > > iteration and error checking. > [] > > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > [] > > @@ -427,40 +430,36 @@ int intel_svm_unbind_mm(struct device *dev, > > int pasid) > [] > > + for_each_svm_dev(sdev, svm, dev) { > > + ret = 0; > > + sdev->users--; > > + if (!sdev->users) { > > This might be better by reducing indentation here too > > if (sdev->users) > break; > > > + list_del_rcu(&sdev->list); > > to reduce indentation 1 level below this Sounds good but perhaps we can do this in a separate patch. > > > + /* Flush the PASID cache and IOTLB for > > this device. > > + * Note that we do depend on the hardware > > *not* using > > + * the PASID any more. Just as we depend > > on other > > + * devices never using PASIDs that they > > have no right > > + * to use. We have a *shared* PASID table, > > because it's > > + * large and has to be physically > > contiguous. So it's > > + * hard to be as defensive as we might > > like. */ > > + intel_pasid_tear_down_entry(iommu, dev, > > svm->pasid); > > + intel_flush_svm_range_dev(svm, sdev, 0, > > -1, 0); > > + kfree_rcu(sdev, rcu); > > + > > + if (list_empty(&svm->devs)) { > > + ioasid_free(svm->pasid); > > + if (svm->mm) > > + > > mmu_notifier_unregister(&svm->notifier, svm->mm); > > + list_del(&svm->list); > > + /* We mandate that no page faults > > may be outstanding > > + * for the PASID when > > intel_svm_unbind_mm() is called. > > + * If that is not obeyed, subtle > > errors will happen. > > + * Let's make them less subtle... > > */ > > + memset(svm, 0x6b, sizeof(*svm)); > > + kfree(svm); > > } > > - break; > > } > > + break; > > } > > out: > > mutex_unlock(&pasid_mutex); > [Jacob Pan]