From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B6EC0044D for ; Wed, 4 Dec 2019 08:40:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54F66206DF for ; Wed, 4 Dec 2019 08:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbfLDIkl (ORCPT ); Wed, 4 Dec 2019 03:40:41 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:54655 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbfLDIkl (ORCPT ); Wed, 4 Dec 2019 03:40:41 -0500 Received: from localhost (lfbn-1-1480-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7C3FD200016; Wed, 4 Dec 2019 08:40:36 +0000 (UTC) Date: Wed, 4 Dec 2019 09:40:36 +0100 From: Alexandre Belloni To: Mao Wenan Cc: eddie.huang@mediatek.com, sean.wang@mediatek.com, a.zummo@towertech.it, matthias.bgg@gmail.com, dan.carpenter@oracle.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH v2 -next] rtc: mt6397: drop free_irq of devm_xx allocated irq Message-ID: <20191204084036.GK909634@piout.net> References: <20191204063444.GF1765@kadam> <20191204072826.117432-1-maowenan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204072826.117432-1-maowenan@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12/2019 15:28:26+0800, Mao Wenan wrote: > rtc->irq is requested by devm_request_threaded_irq, > and request_threaded_irq. IRQs requested with this > function will be automatically freed on driver detach. > This patch remove unused error label as well. > > Reported-by: Hulk Robot > Signed-off-by: Mao Wenan > --- > v2: remove error label as Dan Carpenter suggest. > drivers/rtc/rtc-mt6397.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 5249fc99fd5f..14f3c4915260 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) > rtc->rtc_dev->ops = &mtk_rtc_ops; > > ret = rtc_register_device(rtc->rtc_dev); > - if (ret) > - goto out_free_irq; > - > - return 0; > - > -out_free_irq: > - free_irq(rtc->irq, rtc); > return ret; Maybe return rtc_register_device(rtc->rtc_dev); > } > > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com