From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D494C43603 for ; Wed, 4 Dec 2019 18:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C10C2081B for ; Wed, 4 Dec 2019 18:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482715; bh=tmPBE1L64k7gFUNouMWYajVti7VOhZkUSGOVv4eEhyg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=p7tj1wJY60TgrYlFLAnv3ov8MMH4zF6x0LD6sIb0IZvKbIOTNIpy2XyMkyB0elip4 4Ayo58xGIu4kvn9ADzxHNU0+yThcCAFNAJOhT735YJzLpNOQjU18oJYjUgiRM2tbbs wfkaPlhhxbFUDDDVLy6Jwir1g9pBGIbLcUW8ElRs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730337AbfLDSFN (ORCPT ); Wed, 4 Dec 2019 13:05:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:51314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730327AbfLDSFI (ORCPT ); Wed, 4 Dec 2019 13:05:08 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2210A20659; Wed, 4 Dec 2019 18:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482707; bh=tmPBE1L64k7gFUNouMWYajVti7VOhZkUSGOVv4eEhyg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qefD5XYMAtRy5IIp+fhB7kWtS7PkAMkwe0j9CM1507GmBGi0AmnE4edWFH2FKSNxD GqCCfbbCLkc2Tugo3qOWLx+NIoZaAEWW4AofbNHF3EkJuxXFvtl4BSVZr3yS07fRyJ oylB7B55yD8GyBRYzusIif3SOLge+KgqWEypZo8k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Mark Brown , Sasha Levin Subject: [PATCH 4.14 104/209] regulator: tps65910: fix a missing check of return value Date: Wed, 4 Dec 2019 18:55:16 +0100 Message-Id: <20191204175329.020935217@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit cd07e3701fa6a4c68f8493ee1d12caa18d46ec6a ] tps65910_reg_set_bits() may fail. The fix checks if it fails, and if so, returns with its error code. Signed-off-by: Kangjie Lu Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/tps65910-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 81672a58fcc23..194fa0cbbc048 100644 --- a/drivers/regulator/tps65910-regulator.c +++ b/drivers/regulator/tps65910-regulator.c @@ -1102,8 +1102,10 @@ static int tps65910_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pmic); /* Give control of all register to control port */ - tps65910_reg_set_bits(pmic->mfd, TPS65910_DEVCTRL, + err = tps65910_reg_set_bits(pmic->mfd, TPS65910_DEVCTRL, DEVCTRL_SR_CTL_I2C_SEL_MASK); + if (err < 0) + return err; switch (tps65910_chip_id(tps65910)) { case TPS65910: -- 2.20.1