From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EE7C43603 for ; Wed, 4 Dec 2019 18:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54DBA20674 for ; Wed, 4 Dec 2019 18:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482895; bh=HyRnJ4hHIIT88R4IE4XWdBuwVdb6Ox6saxvkkrM4gqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2BW1zfCq2iDznLP5vNv5O5qwojRdbrF8JI+4Byp5XMYonFNKCYYOgoRdQiczJAvNq 54hpvlA7RVKGndHFbTDUCFFEVfkMCfSW8aFhNyGLjmR4iLK9iAg9Peuy/K1jDkh5ZS 9N/uRKv6z/+bXltwSWHXLeNcK2W1DWJLRv9Npebk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730471AbfLDSIO (ORCPT ); Wed, 4 Dec 2019 13:08:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:59520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730874AbfLDSIL (ORCPT ); Wed, 4 Dec 2019 13:08:11 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0C5B20674; Wed, 4 Dec 2019 18:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482891; bh=HyRnJ4hHIIT88R4IE4XWdBuwVdb6Ox6saxvkkrM4gqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gX26a6xjWek+4SldlZWU6w2Y0Sl6cAudjtBvpWPSvGHWOQL6TTVSsgRZOaIF9ifKg 1lY+qLUjelm8UtzDMJpDTHiF6CQ65I8yfGmhlPqxqNASumCYw8QpRt7GwTmG7p4SVr Ux1GZkie5hBMcsLPLKwuyou1CI6rxhLTMn49f5Ho= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Rutherford , Jon Maloy , "David S. Miller" Subject: [PATCH 4.14 175/209] tipc: fix link name length check Date: Wed, 4 Dec 2019 18:56:27 +0100 Message-Id: <20191204175335.535746226@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Rutherford [ Upstream commit fd567ac20cb0377ff466d3337e6e9ac5d0cb15e4 ] In commit 4f07b80c9733 ("tipc: check msg->req data len in tipc_nl_compat_bearer_disable") the same patch code was copied into routines: tipc_nl_compat_bearer_disable(), tipc_nl_compat_link_stat_dump() and tipc_nl_compat_link_reset_stats(). The two link routine occurrences should have been modified to check the maximum link name length and not bearer name length. Fixes: 4f07b80c9733 ("tipc: check msg->reg data len in tipc_nl_compat_bearer_disable") Signed-off-by: John Rutherford Acked-by: Jon Maloy Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/netlink_compat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -539,7 +539,7 @@ static int tipc_nl_compat_link_stat_dump if (len <= 0) return -EINVAL; - len = min_t(int, len, TIPC_MAX_BEARER_NAME); + len = min_t(int, len, TIPC_MAX_LINK_NAME); if (!string_is_valid(name, len)) return -EINVAL; @@ -821,7 +821,7 @@ static int tipc_nl_compat_link_reset_sta if (len <= 0) return -EINVAL; - len = min_t(int, len, TIPC_MAX_BEARER_NAME); + len = min_t(int, len, TIPC_MAX_LINK_NAME); if (!string_is_valid(name, len)) return -EINVAL;