From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53333C2D0BF for ; Thu, 5 Dec 2019 16:02:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A00122525 for ; Thu, 5 Dec 2019 16:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575561767; bh=lMnO+rWwvbvlRGsDD/qOZFz4FisJZWp5f44VpRhrrmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c3yvlQjHpdMlSVySgvKqtPt/ZbDhU/hi9kc3AvUvfq4W7cqGkui1AfQxOTaW1VGs1 e1odzf3GNV1a9JFV/MijwJIeRPL3Awvk2Lmoqe0FdlayzuZIFGcxO0NFSxyHBq0Mt6 i1OdOiqb+9jOYhvoUojSUxtGDAjcjrNGOxI1Cewk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729890AbfLEQCq (ORCPT ); Thu, 5 Dec 2019 11:02:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:43216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfLEQCq (ORCPT ); Thu, 5 Dec 2019 11:02:46 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2CB4206DB; Thu, 5 Dec 2019 16:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575561765; bh=lMnO+rWwvbvlRGsDD/qOZFz4FisJZWp5f44VpRhrrmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c5a8PFL/ROjGYadcziWrl4SW+usO0sfBvNAGStPsepBtWK7Tv/ea6iT9wB2tlaa1j qvA9luZd03j8qx7x+chpVEU7v1i9NBnmuDEAjDBj9Y3g/uNsM92xCKvdRSveRFxBwj owpxdHs/j5dSEz/uUAYGh0e5dUf4uyXawsvvVGNY= Date: Thu, 5 Dec 2019 17:02:43 +0100 From: Greg KH To: Krzysztof Kozlowski Cc: Hyunki Koo , jslaby@suse.com, linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" , kkoos00@gmail.com, Shinbeom Choi , Hyunki Koo Subject: Re: [PATCH] tty: serial: samsung: support driver modulization Message-ID: <20191205160243.GA757198@kroah.com> References: <20191201075914.23512-1-kkoos00@naver.com> <20191201080314.GA3716559@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 05, 2019 at 04:36:48PM +0100, Krzysztof Kozlowski wrote: > On Sun, 1 Dec 2019 at 09:05, Greg KH wrote: > > > > On Sun, Dec 01, 2019 at 04:59:14PM +0900, Hyunki Koo wrote: > > > From: Shinbeom Choi > > > > > > This commit enables modulization of samsung uart driver. > > > > > > There was no way to make use of this driver in other module, > > > because uart functions were static. > > > > > > By exporting required functions, user can use this driver > > > in other module. > > > > > > Signed-off-by: Shinbeom Choi > > > Signed-off-by: Hyunki Koo > > > --- > > > drivers/tty/serial/samsung.h | 32 ++++++++++++ > > > drivers/tty/serial/samsung_tty.c | 85 +++++++++++++++----------------- > > > 2 files changed, 73 insertions(+), 44 deletions(-) > > > > > > diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h > > > index f93022113f59..25be0962284d 100644 > > > --- a/drivers/tty/serial/samsung.h > > > +++ b/drivers/tty/serial/samsung.h > > > @@ -144,4 +144,36 @@ static inline void s3c24xx_clear_bit(struct uart_port *port, int idx, > > > local_irq_restore(flags); > > > } > > > > > > +#if defined(CONFIG_ARCH_EXYNOS) > > > +#define EXYNOS_COMMON_SERIAL_DRV_DATA \ > > > + .info = &(struct s3c24xx_uart_info) { \ > > > + .name = "Samsung Exynos UART", \ > > > + .type = PORT_S3C6400, \ > > > + .has_divslot = 1, \ > > > + .rx_fifomask = S5PV210_UFSTAT_RXMASK, \ > > > + .rx_fifoshift = S5PV210_UFSTAT_RXSHIFT, \ > > > + .rx_fifofull = S5PV210_UFSTAT_RXFULL, \ > > > + .tx_fifofull = S5PV210_UFSTAT_TXFULL, \ > > > + .tx_fifomask = S5PV210_UFSTAT_TXMASK, \ > > > + .tx_fifoshift = S5PV210_UFSTAT_TXSHIFT, \ > > > + .def_clk_sel = S3C2410_UCON_CLKSEL0, \ > > > + .num_clks = 1, \ > > > + .clksel_mask = 0, \ > > > + .clksel_shift = 0, \ > > > + }, \ > > > + .def_cfg = &(struct s3c2410_uartcfg) { \ > > > + .ucon = S5PV210_UCON_DEFAULT, \ > > > + .ufcon = S5PV210_UFCON_DEFAULT, \ > > > + .has_fracval = 1, \ > > > + } \ > > > + > > > +#endif > > > + > > > +int s3c24xx_serial_get_ports(struct s3c24xx_uart_port **ourport, int index); > > > +int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > > > + struct platform_device *platdev); > > > +int s3c24xx_serial_unregister_port(struct platform_device *dev); > > > +int s3c24xx_serial_suspend(struct device *dev); > > > +int s3c24xx_serial_resume(struct device *dev); > > > +int s3c24xx_serial_resume_noirq(struct device *dev); > > > #endif > > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > > index 83fd51607741..15414ecd9008 100644 > > > --- a/drivers/tty/serial/samsung_tty.c > > > +++ b/drivers/tty/serial/samsung_tty.c > > > @@ -1735,7 +1735,7 @@ static int s3c24xx_serial_enable_baudclk(struct s3c24xx_uart_port *ourport) > > > * initialise a single serial port from the platform device given > > > */ > > > > > > -static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > > > +int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > > > struct platform_device *platdev) > > > { > > > struct uart_port *port = &ourport->port; > > > @@ -1842,12 +1842,24 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > > > /* reset the fifos (and setup the uart) */ > > > s3c24xx_serial_resetport(port, cfg); > > > > > > + if (!s3c24xx_uart_drv.state) { > > > + ret = uart_register_driver(&s3c24xx_uart_drv); > > > + if (ret < 0) { > > > + dev_err(port->dev, "Failed to register Samsung UART driver\n"); > > > + return ret; > > > + } > > > + } > > > + > > > + dbg("%s: adding port\n", __func__); > > > + uart_add_one_port(&s3c24xx_uart_drv, &ourport->port); > > > + > > > return 0; > > > > > > err: > > > port->mapbase = 0; > > > return ret; > > > } > > > +EXPORT_SYMBOL_GPL(s3c24xx_serial_init_port); > > > > Why are you exporting all of these functions? What other code uses > > them? Why are you converting them all to global functions I don't see > > any other in-kernel callers, so why are those changes needed here? > > > > totally confused, > > I cannot find the original email from Hyunki on mailing lists (neither > LKML nor serial) so this was not even public till Greg replied. I think it might have been sent in html format. > Anyway, probably this is for new Android and some out-of-tree usage... > but it is wrong. Making the driver be able to be built as a module is a good thing, no matter what project is causing the work to have happen. And yes, it's Android :) thanks, greg k-h