From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57ACDC43603 for ; Fri, 6 Dec 2019 02:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 299672075C for ; Fri, 6 Dec 2019 02:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbfLFC2y (ORCPT ); Thu, 5 Dec 2019 21:28:54 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:53196 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfLFC2x (ORCPT ); Thu, 5 Dec 2019 21:28:53 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1id3MR-0003pE-7y; Fri, 06 Dec 2019 02:28:51 +0000 Date: Fri, 6 Dec 2019 02:28:51 +0000 From: Al Viro To: Linus Torvalds Cc: Linux Kernel Mailing List , linux-fsdevel , Ritesh Harjani Subject: Re: [git pull] vfs.git d_inode/d_flags barriers Message-ID: <20191206022851.GM4203@ZenIV.linux.org.uk> References: <20191206013819.GL4203@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 05, 2019 at 06:15:54PM -0800, Linus Torvalds wrote: > On Thu, Dec 5, 2019 at 5:38 PM Al Viro wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes > > I'm not pulling this. > > Commit 6c2d4798a8d1 ("new helper: lookup_positive_unlocked()") results > in a new - and valid - compiler warning: > > fs/quota/dquot.c: In function ‘dquot_quota_on_mount’: > fs/quota/dquot.c:2499:1: warning: label ‘out’ defined but not used > [-Wunused-label] > 2499 | out: > | ^~~ > > and I don't want to see new warnings in my tree. > > I wish linux-next would complain about warnings (assuming this had > been there), because they aren't ok. Fixed... Could you pull #fixes1 instead? diff is literally removal of one line; updated shortlog/diffstat follows: The following changes since commit 3e5aeec0e267d4422a4e740ce723549a3098a4d1: cramfs: fix usage on non-MTD device (2019-11-23 21:44:49 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes1 for you to fetch changes up to 7fcd59b64a7b69718cc851865a1578138b481541: fs/namei.c: fix missing barriers when checking positivity (2019-12-05 21:04:35 -0500) ---------------------------------------------------------------- Al Viro (4): fs/namei.c: pull positivity check into follow_managed() new helper: lookup_positive_unlocked() fix dget_parent() fastpath race fs/namei.c: fix missing barriers when checking positivity fs/cifs/cifsfs.c | 7 +------ fs/dcache.c | 6 ++++-- fs/debugfs/inode.c | 6 +----- fs/kernfs/mount.c | 2 +- fs/namei.c | 56 ++++++++++++++++++++++++++++---------------------- fs/nfsd/nfs3xdr.c | 4 +--- fs/nfsd/nfs4xdr.c | 11 +--------- fs/overlayfs/namei.c | 24 ++++++++-------------- fs/quota/dquot.c | 8 +------- include/linux/dcache.h | 5 +++++ include/linux/namei.h | 1 + 11 files changed, 56 insertions(+), 74 deletions(-)