From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39F1C2D0C0 for ; Fri, 6 Dec 2019 07:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B874D24679 for ; Fri, 6 Dec 2019 07:55:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JjCpjTdl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbfLFHzo (ORCPT ); Fri, 6 Dec 2019 02:55:44 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38503 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfLFHzo (ORCPT ); Fri, 6 Dec 2019 02:55:44 -0500 Received: by mail-pg1-f194.google.com with SMTP id a33so2692794pgm.5; Thu, 05 Dec 2019 23:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b6sEPD+7f9rrFrxPhOl7e8WDEqgliGQGOKb/WtjO5Ls=; b=JjCpjTdldUb5Ee7hf+FyCpro5m3bK+w+nKTnerlO61bkactO3Pyg/DYFivgT6NI8PC B84PnZ/bCNOr4p+Wn1tV2ToQPvy1XTdvyjLTTWTw3Bzs/1VNYstBAOfITJT+uZKlmMgu FjPUmvVbd1Kouub0lAIwtbreOKXF7zzrgdp0Sq571C/7L1rY/ph5vovRfrbuGKiRqM8n kCC12Ye/dNaLbAoEcrXrmKI6QMG2tJFKVn75gQajCMFMcbDpi7DEe4mnmMyzru7bCH9Q vcDpwm+GtdGap0BMgwSEzhqlnN06LkyGZGzJbRConkvc1zdr7h04fs0j6s8xV0vgr/H/ nWeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b6sEPD+7f9rrFrxPhOl7e8WDEqgliGQGOKb/WtjO5Ls=; b=fegqUmbvyGXUU1z8cA5iS8oRmzwMxwMmovO3yfD+fWpZambgqHFHX6HNzj8wU/LBZD ycxtRAlJIykeL30cYCZNk4XdfbEUgb1yt1tSS/8043Eba/Jnsq5861VTvxpSOn5hnj0l aCd7zGXl1UBpBNGFC/EeyhKZPLfhdFmlY1RDZf5G8n+P2CrBe9QddBF9uD1LjjA6ZPv0 lt0vjSUOs4FW5O7ZWnTzBCGYh/Aokc76vNqr/cdZ6TCY+fZgx/Kr7eMK013GghEqYTYR l35BDZz49Nro/DqE2tY3alD8mJFAmyWE5isrYriInkTzFuWycfzIneu+V7y8wRsspLGk nS3w== X-Gm-Message-State: APjAAAUr/lUnVnfnkWahIcMengqpZYTBR6Igg9Yrcycmw7nnitNckfy8 oUYCNWTk0FsompfOBeeCa9Q= X-Google-Smtp-Source: APXvYqxYsMlnlr32fMRFumCNpuqkIcvwFIN120LLG60hSJicwgrN05/T+i/EfDN6esL3zZuRH8S3dA== X-Received: by 2002:aa7:90c4:: with SMTP id k4mr12870805pfk.216.1575618943947; Thu, 05 Dec 2019 23:55:43 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id q3sm15890301pfc.114.2019.12.05.23.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 23:55:43 -0800 (PST) From: Chuhong Yuan Cc: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] thermal: intel: fix unmatched pci_release_region Date: Fri, 6 Dec 2019 15:55:31 +0800 Message-Id: <20191206075531.18637-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver calls pci_request_regions() in probe and uses pci_release_regions() in probe failure. However, it calls pci_release_region() in remove, which does match the other two calls. Use pci_release_regions() instead to unify them. Signed-off-by: Chuhong Yuan --- drivers/thermal/intel/intel_pch_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c index 4f0bb8f502e1..5f7798b8d35f 100644 --- a/drivers/thermal/intel/intel_pch_thermal.c +++ b/drivers/thermal/intel/intel_pch_thermal.c @@ -365,7 +365,7 @@ static void intel_pch_thermal_remove(struct pci_dev *pdev) thermal_zone_device_unregister(ptd->tzd); iounmap(ptd->hw_base); pci_set_drvdata(pdev, NULL); - pci_release_region(pdev, 0); + pci_release_regions(pdev); pci_disable_device(pdev); } -- 2.24.0