From: Kees Cook <keescook@chromium.org>
To: SeongJae Park <sjpark@amazon.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, sj38.park@gmail.com,
SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH 2/2] kselftest: Support old perl versions
Date: Sat, 7 Dec 2019 10:47:59 -0800 [thread overview]
Message-ID: <201912071047.D7BDF3DD9F@keescook> (raw)
In-Reply-To: <20191202114221.827-2-sjpark@amazon.com>
On Mon, Dec 02, 2019 at 12:42:21PM +0100, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> On an old perl such as v5.10.1, `kselftest/prefix.pl` gives below error
> message:
>
> Can't locate object method "autoflush" via package "IO::Handle" at kselftest/prefix.pl line 10.
>
> This commit fixes the error by explicitly specifying the use of the
> `IO::Handle` package.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
Good catch!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> tools/testing/selftests/kselftest/prefix.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kselftest/prefix.pl b/tools/testing/selftests/kselftest/prefix.pl
> index ec7e48118183..31f7c2a0a8bd 100755
> --- a/tools/testing/selftests/kselftest/prefix.pl
> +++ b/tools/testing/selftests/kselftest/prefix.pl
> @@ -3,6 +3,7 @@
> # Prefix all lines with "# ", unbuffered. Command being piped in may need
> # to have unbuffering forced with "stdbuf -i0 -o0 -e0 $cmd".
> use strict;
> +use IO::Handle;
>
> binmode STDIN;
> binmode STDOUT;
> --
> 2.17.1
>
--
Kees Cook
next prev parent reply other threads:[~2019-12-07 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 11:42 [PATCH 1/2] kselftest/runner: Print new line in print of timeout log SeongJae Park
2019-12-02 11:42 ` [PATCH 2/2] kselftest: Support old perl versions SeongJae Park
2019-12-07 18:47 ` Kees Cook [this message]
2019-12-11 17:20 ` shuah
2019-12-06 19:31 ` [PATCH 1/2] kselftest/runner: Print new line in print of timeout log SeongJae Park
2019-12-07 18:47 ` Kees Cook
2019-12-11 17:19 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912071047.D7BDF3DD9F@keescook \
--to=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox