From: Frederic Weisbecker <frederic@kernel.org>
To: Paul Orlyk <pavel.orlik@smartexe.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Wanpeng Li <wanpengli@tencent.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rik van Riel <riel@surriel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yauheni Kaliuta <yauheni.kaliuta@redhat.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 3/6] procfs: Use all-in-one vtime aware kcpustat accessor
Date: Mon, 9 Dec 2019 16:50:46 +0100 [thread overview]
Message-ID: <20191209155046.GA32009@lenoir> (raw)
In-Reply-To: <14ca94e3-5320-6f95-9d76-101dccb7e1b5@smartexe.com>
On Sun, Dec 08, 2019 at 05:57:47PM +0200, Paul Orlyk wrote:
> Looks like a copy-paste error. I think it should be:
>
> - guest_nice += cpustat[CPUTIME_USER];
> + guest_nice += cpustat[CPUTIME_GUEST_NICE];
>
> and
>
> - guest_nice = cpustat[CPUTIME_USER];
> + guest_nice = cpustat[CPUTIME_GUEST_NICE];
>
> With best regards,
> Paul Orlyk
Yes the fix should be applied soonish:
https://lore.kernel.org/lkml/20191205020344.14940-1-frederic@kernel.org/
Thanks.
>
> On 11/21/19 4:44 AM, Frederic Weisbecker wrote:
> > + guest += cpustat[CPUTIME_GUEST];
> > + guest_nice += cpustat[CPUTIME_USER];
> > + sum += kstat_cpu_irqs_sum(i);
> >
> > + guest = cpustat[CPUTIME_GUEST];
> > + guest_nice = cpustat[CPUTIME_USER];
> > seq_printf(p, "cpu%d", i);
next prev parent reply other threads:[~2019-12-09 15:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 2:44 [PATCH 0/6] sched/nohz: Make the rest of kcpustat vtime aware v3 Frederic Weisbecker
2019-11-21 2:44 ` [PATCH 1/6] sched/cputime: Support other fields on kcpustat_field() Frederic Weisbecker
2019-11-21 16:48 ` [tip: sched/core] " tip-bot2 for Frederic Weisbecker
2019-11-21 2:44 ` [PATCH 2/6] sched/vtime: Bring up complete kcpustat accessor Frederic Weisbecker
2019-11-21 16:48 ` [tip: sched/core] " tip-bot2 for Frederic Weisbecker
2019-12-28 20:56 ` [PATCH 2/6] " Chris Wilson
2019-12-30 1:08 ` Frederic Weisbecker
2019-12-30 9:04 ` [PATCH] sched/vtime: Prevent unstable evaluation of WARN(vtime->state) Chris Wilson
2019-12-30 17:39 ` Frederic Weisbecker
2019-11-21 2:44 ` [PATCH 3/6] procfs: Use all-in-one vtime aware kcpustat accessor Frederic Weisbecker
2019-11-21 16:48 ` [tip: sched/core] " tip-bot2 for Frederic Weisbecker
2019-12-08 15:57 ` [PATCH 3/6] " Paul Orlyk
2019-12-09 15:50 ` Frederic Weisbecker [this message]
2019-11-21 2:44 ` [PATCH 4/6] cpufreq: Use vtime aware kcpustat accessors for user time Frederic Weisbecker
2019-11-21 16:48 ` [tip: sched/core] " tip-bot2 for Frederic Weisbecker
2019-11-21 2:44 ` [PATCH 5/6] leds: Use all-in-one vtime aware kcpustat accessor Frederic Weisbecker
2019-11-21 6:58 ` Ingo Molnar
2019-11-21 14:14 ` Frederic Weisbecker
2019-11-21 16:49 ` Ingo Molnar
2019-11-21 16:48 ` [tip: sched/core] " tip-bot2 for Frederic Weisbecker
2019-11-21 2:44 ` [PATCH 6/6] rackmeter: Use " Frederic Weisbecker
2019-11-21 16:48 ` [tip: sched/core] " tip-bot2 for Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2019-11-19 23:22 [PATCH 0/6] sched/nohz: Make the rest of kcpustat vtime aware v2 Frederic Weisbecker
2019-11-19 23:22 ` [PATCH 3/6] procfs: Use all-in-one vtime aware kcpustat accessor Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209155046.GA32009@lenoir \
--to=frederic@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel.orlik@smartexe.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=wanpengli@tencent.com \
--cc=yauheni.kaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox