From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6C4C43603 for ; Mon, 9 Dec 2019 15:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 508972080D for ; Mon, 9 Dec 2019 15:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575906651; bh=z50cp8vM2SpBO12/oa6Uc1IyYJi1iEKeInGOuXNLqJc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=StbTAVlv//uK6ZKkcAazUdTQMO961EnMb5JUlFSZTfjUnS4eVKViORfztFV+kSL85 vSbFXZi+EHYDC17+bGIlxY02WMgDqdnwNX9uSEuMTHUGVF9xfFvF+N+ITqVqVyDT72 2sJlDppxEgsPps7tAO6C6WRuqGCe6hDyc1xlXwtc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbfLIPuu (ORCPT ); Mon, 9 Dec 2019 10:50:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:45352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfLIPut (ORCPT ); Mon, 9 Dec 2019 10:50:49 -0500 Received: from localhost (lfbn-ncy-1-150-155.w83-194.abo.wanadoo.fr [83.194.232.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9788207FF; Mon, 9 Dec 2019 15:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575906649; bh=z50cp8vM2SpBO12/oa6Uc1IyYJi1iEKeInGOuXNLqJc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G113+63wCz0RXQ9kgpAE/x7hV+E2w9Sjx5PKBJmo48dPBblk1XZM9lq+oYewPTmdK SCDRMAR4aDcQ0AdnwwADDvKxDP+LRa2XYJP9HLU4kG477ZmOa0Sq5VqbqBRPSvFTwn +wl+4x28mBKLHAMAInFH4R+32BkYoqkrObHxkARY= Date: Mon, 9 Dec 2019 16:50:46 +0100 From: Frederic Weisbecker To: Paul Orlyk Cc: Peter Zijlstra , Ingo Molnar , LKML , Jacek Anaszewski , Wanpeng Li , "Rafael J . Wysocki" , Benjamin Herrenschmidt , Rik van Riel , Thomas Gleixner , Yauheni Kaliuta , Viresh Kumar , Pavel Machek Subject: Re: [PATCH 3/6] procfs: Use all-in-one vtime aware kcpustat accessor Message-ID: <20191209155046.GA32009@lenoir> References: <20191121024430.19938-1-frederic@kernel.org> <20191121024430.19938-4-frederic@kernel.org> <14ca94e3-5320-6f95-9d76-101dccb7e1b5@smartexe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14ca94e3-5320-6f95-9d76-101dccb7e1b5@smartexe.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 08, 2019 at 05:57:47PM +0200, Paul Orlyk wrote: > Looks like a copy-paste error. I think it should be: > > - guest_nice += cpustat[CPUTIME_USER]; > + guest_nice += cpustat[CPUTIME_GUEST_NICE]; > > and > > - guest_nice = cpustat[CPUTIME_USER]; > + guest_nice = cpustat[CPUTIME_GUEST_NICE]; > > With best regards, > Paul Orlyk Yes the fix should be applied soonish: https://lore.kernel.org/lkml/20191205020344.14940-1-frederic@kernel.org/ Thanks. > > On 11/21/19 4:44 AM, Frederic Weisbecker wrote: > > + guest += cpustat[CPUTIME_GUEST]; > > + guest_nice += cpustat[CPUTIME_USER]; > > + sum += kstat_cpu_irqs_sum(i); > > > > + guest = cpustat[CPUTIME_GUEST]; > > + guest_nice = cpustat[CPUTIME_USER]; > > seq_printf(p, "cpu%d", i);