From: Mark Brown <broonie@kernel.org>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Subject: Re: Regulator probe on demand (or circular dependencies)
Date: Mon, 9 Dec 2019 16:37:55 +0000 [thread overview]
Message-ID: <20191209163755.GF5483@sirena.org.uk> (raw)
In-Reply-To: <23236201-a387-7257-35a4-ee4ed2f6bfd0@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Fri, Dec 06, 2019 at 04:38:04PM +0000, Kieran Bingham wrote:
> The MAX9286 also exposes 2 GPIO pins, as such I have configured the
> MAX9286 driver [1] to expose a gpio-chip [2].
So this seems like a MFD then? The nice thing about using the MFD
subsystem is that it means that the drivers for the various subsystems
on the device can instantiate in any order and defer separately without
interfering with each other which seems like it's the issue here.
> - is there anything I can do here within regulator_dev_lookup() to
> attempt creating the regulator_dev 'on-demand' when
> of_find_regulator_by_node(node) returns empty? (or is that crazy, and
> just a rabbit-hole?)
This seems like a terrible idea, you'll have a half baked regulator in
the system which will need special casing all over the place and
doubtless be an ongoing source of bugs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-12-09 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 16:38 Regulator probe on demand (or circular dependencies) Kieran Bingham
2019-12-09 16:37 ` Mark Brown [this message]
2019-12-09 17:03 ` Kieran Bingham
2019-12-09 17:13 ` Mark Brown
2019-12-09 17:16 ` Niklas Söderlund
2019-12-11 22:42 ` Kieran Bingham
2019-12-12 15:56 ` Mark Brown
2019-12-12 16:18 ` Geert Uytterhoeven
2019-12-12 16:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209163755.GF5483@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox